Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] Livechat: Allow resolving external image and media blocks

Open cauefcr opened this issue 3 years ago • 1 comments

OC-198

Proposed changes (including videos or screenshots)

Allow external urls to be viewed on livechat.

Issue(s)

issue#26511

Steps to test or reproduce

paste the below message on a chat, and check if the image appears

![if you can read this on rocket.chat the bug still exists](https://assets.digitalocean.com/articles/alligator/boo.svg)

Further comments

Fixes botpress integration issue

Fixes #26511

cauefcr avatar Nov 28 '22 20:11 cauefcr

Codecov Report

Merging #27387 (5944a30) into develop (c98c719) will increase coverage by 0.92%. The diff coverage is n/a.

:exclamation: Current head 5944a30 differs from pull request most recent head 6c19e0b. Consider uploading reports for the commit 6c19e0b to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27387      +/-   ##
===========================================
+ Coverage    41.31%   42.23%   +0.92%     
===========================================
  Files          839      812      -27     
  Lines        18269    17736     -533     
  Branches      2085     1990      -95     
===========================================
- Hits          7548     7491      -57     
+ Misses       10432     9957     -475     
+ Partials       289      288       -1     
Flag Coverage Δ
e2e 42.23% <ø> (+0.92%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Nov 28 '22 21:11 codecov[bot]

@MartinSchoeler can you help us with the FE review? @cauefcr , did you create the task for doing the UI tests for this PR as a separate operation? 👀

KevLehman avatar Nov 30 '22 18:11 KevLehman

@cauefcr , did you create the task for doing the UI tests for this PR as a separate operation?

No, I had a UI test working before, but the markdown stopped being parsed, the only way to test this is with an app, which QA already has in their hands, so this PR has no tests.

cauefcr avatar Dec 01 '22 13:12 cauefcr