Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] No preview for links without schema

Open xareyli opened this issue 3 years ago • 2 comments

Proposed changes (including videos or screenshots)

Changed the way of searching urls in messages.

Was forGH2

Now forGH

Issue(s)

Closes #27235

Steps to test or reproduce

1.) Write a message containing a link without schema

Further comments

Tests and linters were successful on my machine.

xareyli avatar Nov 23 '22 16:11 xareyli

This pull request introduces 1 alert when merging 8b1e1360e666e9b6233de5cf5fe57cec75198a8d into 39ebc6759905ec11990245b020b6da9e123f4aa6 - view on LGTM.com

new alerts:

  • 1 for Duplicate character in character class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 23 '22 17:11 lgtm-com[bot]

This pull request introduces 1 alert when merging b9fa0b5dd502da319ee34aba191df73d7d41222c into 80fb0731ae342f034f3b3bbe87907d8c4c55bdb7 - view on LGTM.com

new alerts:

  • 1 for Duplicate character in character class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 24 '22 13:11 lgtm-com[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.78%. Comparing base (84b171b) to head (ea8cf92). Report is 2439 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27325      +/-   ##
===========================================
- Coverage    45.16%   42.78%   -2.38%     
===========================================
  Files          749      701      -48     
  Lines        14533    13415    -1118     
  Branches      2240     2093     -147     
===========================================
- Hits          6564     5740     -824     
+ Misses        7662     7403     -259     
+ Partials       307      272      -35     
Flag Coverage Δ
e2e 42.76% <100.00%> (-2.36%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Mar 29 '23 14:03 codecov[bot]