Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

No preview for links without schema

Open paulchen opened this issue 3 years ago • 3 comments

Description:

Links without schema are clickable, but no preview is generated.

Steps to reproduce:

  1. Write a message containing a link without schema (e.g. github.com/RocketChat/Rocket.Chat/ ).

Expected behavior:

A link preview is generated as it is the case when the link contains a schema:

image

Actual behavior:

No link preview is generated:

image

I would expect this to work as the link is clickable, meaning that Rocket.Chat seems to use some default schema (I assume, http or https).

Server Setup Information:

  • Version of Rocket.Chat Server: 5.3.0
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • MongoDB Version: 5.0.13 / wiredTiger (oplog Aktiviert)

Client Setup Information

This behaviour is independent from browser and operating system.

paulchen avatar Nov 10 '22 19:11 paulchen

I would like to look into this matter, If there's no problem.. One thing, Can you guide me the revelant folder or anything that can help me get started @paulchen @dudanogueira ?

varunsh17 avatar Nov 14 '22 17:11 varunsh17

@dudanogueira please review https://github.com/RocketChat/Rocket.Chat/pull/27325

xareyli avatar Nov 23 '22 16:11 xareyli

I have added the requested changes, can anyone please check PR: #27235

apurb-coder avatar Feb 12 '24 17:02 apurb-coder