Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] Showing Workspace Section For User Having LiveChat Manager Permission

Open nishant23122000 opened this issue 3 years ago • 2 comments

Proposed changes (including videos or screenshots)

Issue(s)

Closes #27081

Steps to test or reproduce

Please refer #27081 for more details

  1. Log in as livechat-manager user
  2. Open Administration > Workspace menu item Screenshot 2022-12-27 at 11 12 35

Further comments

The Workspace menu shouldn't be visible since the livechat-manager user doesn't have any admin permission.

nishant23122000 avatar Nov 04 '22 11:11 nishant23122000

@filipemarins test cases falling here, I saw your name where you implemented test cases for Rocket.Chat/apps/meteor/tests/unit/client/components/AdministrationList/AdministrationModelList.spec.tsx

can you help me with this?

nishant23122000 avatar Nov 04 '22 11:11 nishant23122000

Codecov Report

Merging #27188 (6514703) into develop (5a0c3a2) will increase coverage by 0.89%. The diff coverage is n/a.

:exclamation: Current head 6514703 differs from pull request most recent head 638302b. Consider uploading reports for the commit 638302b to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27188      +/-   ##
===========================================
+ Coverage    41.00%   41.90%   +0.89%     
===========================================
  Files          838      811      -27     
  Lines        17677    17158     -519     
  Branches      1983     1908      -75     
===========================================
- Hits          7249     7190      -59     
+ Misses       10188     9727     -461     
- Partials       240      241       +1     
Flag Coverage Δ
e2e 41.90% <ø> (+0.89%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 26 '22 22:12 codecov[bot]