Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] Adjusted livechat fallbacks to take null values into account

Open aleksandernsilva opened this issue 3 years ago • 1 comments

OC-209

This pull request fixes the fallbacks from a few livechat methods to take into account null values and fallback to the correct default value instead of breaking the widget.

aleksandernsilva avatar Sep 20 '22 22:09 aleksandernsilva

Codecov Report

Merging #26909 (c2e9a29) into develop (74cd22b) will increase coverage by 1.08%. The diff coverage is n/a.

:exclamation: Current head c2e9a29 differs from pull request most recent head a65fa80. Consider uploading reports for the commit a65fa80 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26909      +/-   ##
===========================================
+ Coverage    39.90%   40.98%   +1.08%     
===========================================
  Files          826      801      -25     
  Lines        18373    17920     -453     
  Branches      2019     1960      -59     
===========================================
+ Hits          7332     7345      +13     
+ Misses       10742    10279     -463     
+ Partials       299      296       -3     
Flag Coverage Δ
e2e 40.98% <ø> (+1.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 20 '22 23:09 codecov[bot]

This pull request introduces 1 alert when merging 05dcba1dc3129eef6452214a88cde5fa8c38a067 into ca43434f44862c30e813efa01b8d69541d3e13f6 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

lgtm-com[bot] avatar Sep 26 '22 16:09 lgtm-com[bot]