Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] Message sequential after message thread preview

Open filipemarins opened this issue 3 years ago • 1 comments

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Message sequential after message thread preview

Before: Screen Shot 2022-09-19 at 11 37 36

After: Screen Shot 2022-09-19 at 11 37 09

filipemarins avatar Sep 19 '22 14:09 filipemarins

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@55e11c4). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #26900   +/-   ##
==========================================
  Coverage           ?   40.84%           
==========================================
  Files              ?      793           
  Lines              ?    17851           
  Branches           ?     1940           
==========================================
  Hits               ?     7291           
  Misses             ?    10263           
  Partials           ?      297           
Flag Coverage Δ
e2e 40.84% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 19 '22 15:09 codecov[bot]

I had to change the code because the solution was introducing a different bug (messages from the same thread were never grouping). and makes no sense testing the functions alone, if the results are mixed, they be tested together

ggazzo avatar Sep 22 '22 20:09 ggazzo