Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[NEW] admin kebab menu

Open filipemarins opened this issue 3 years ago • 2 comments

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Add the new admin kebab menu: Screen Shot 2022-09-14 at 02 59 03

filipemarins avatar Sep 14 '22 06:09 filipemarins

Codecov Report

Merging #26867 (4435b83) into develop (5d3a3d2) will increase coverage by 0.29%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26867      +/-   ##
===========================================
+ Coverage    40.76%   41.06%   +0.29%     
===========================================
  Files          801      801              
  Lines        17919    17918       -1     
  Branches      1958     1958              
===========================================
+ Hits          7305     7358      +53     
+ Misses       10319    10260      -59     
- Partials       295      300       +5     
Flag Coverage Δ
e2e 41.06% <50.00%> (+0.29%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 14 '22 06:09 codecov[bot]

This pull request introduces 1 alert when merging 92ea16084a77241d8bcad4bae1945739a71352fe into 18b7b4b36a4bea791a7479e486e0d5af99e26ba3 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 15 '22 14:09 lgtm-com[bot]

image I'm wondering if this section makes sense , since settings belongs to administration and there is only one item

I believe it was a design decision after I talked with the product team and the idea was to split these admin section.

filipemarins avatar Sep 23 '22 14:09 filipemarins

This was a semi-optimal idea. https://github.com/pbaity/rocketchat-dark-mode/issues/199

chotaire avatar Oct 17 '22 08:10 chotaire