Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] `channels.convertToTeam` endpoint doesn't work when only the `channelName` param is provided

Open matheusbsilva137 opened this issue 3 years ago • 1 comments

Proposed changes (including videos or screenshots)

  • Fix the channels.convertToTeam endpoint not working when the channelName is sent as parameter.

Issue(s)

Steps to test or reproduce

Example request (using cURL):

curl 'http://localhost:3000/api/v1/channels.convertToTeam' \
  -H 'X-Auth-Token: GNNn5trk37eeK2sZvamOHRy1PMRlz_rfMUCwCE6UBlO' \
  -H 'X-User-Id: HZcEBodsm3gFxg2Jt' \
  --data-raw '{"channelName":"channel-example"}'

Further comments

matheusbsilva137 avatar Sep 13 '22 12:09 matheusbsilva137

Codecov Report

Merging #26858 (ad9a658) into develop (daa6aae) will increase coverage by 0.84%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26858      +/-   ##
===========================================
+ Coverage    40.37%   41.21%   +0.84%     
===========================================
  Files          827      802      -25     
  Lines        18246    17806     -440     
  Branches      2033     1971      -62     
===========================================
- Hits          7367     7339      -28     
+ Misses       10583    10174     -409     
+ Partials       296      293       -3     
Flag Coverage Δ
e2e 41.21% <ø> (+0.84%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 13 '22 14:09 codecov[bot]