Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[NEW] Add Markup to QuoteAttachment

Open hugocostadev opened this issue 3 years ago • 2 comments

Proposed changes (including videos or screenshots)

Updating QuoteAttachment styles and structure, now it's using the same wrapper (<MessageBody />) as the normal messages, this also changes the spacing (padding and margins) aligned with the Design

IMPORTANT **: The Figma design and guidelines are included in the task

Actual behavior image

Expected behavior image

Issue(s)

Steps to test or reproduce

Further comments

Due to performance issues, I changed some message parsing behavior, such as:

  • Remove all parsing processes (calling message-parser) into representational components
  • Parse message happens only on useMessages hook on the top-level component <MessageList /> this avoids the hook being called X times per message on the list on render runtime

Other changes:

  • Talking to the design team, it was changed the ThreadPreview message to include bold, italic, and strike emphasis text styles
  • Move the unit test files to test/unit folder to be considered in the CI PIPELINE
  • Created some unit testing file
  • Added md property to Attachments interfaces

hugocostadev avatar Aug 30 '22 19:08 hugocostadev

Codecov Report

Merging #26751 (6bc985d) into develop (3e4b616) will increase coverage by 0.08%. The diff coverage is 65.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26751      +/-   ##
===========================================
+ Coverage    40.77%   40.86%   +0.08%     
===========================================
  Files          791      793       +2     
  Lines        17809    17836      +27     
  Branches      1928     1938      +10     
===========================================
+ Hits          7262     7288      +26     
- Misses       10251    10252       +1     
  Partials       296      296              
Flag Coverage Δ
e2e 40.86% <65.45%> (+0.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 01 '22 19:09 codecov[bot]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Sep 05 '22 20:09 kodiakhq[bot]