Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

Nested Items are broken after 5.x.x

Open IgorOhrimenko opened this issue 3 years ago • 15 comments

Description:

After upgred to 5.x.x nested item does not work in the main chat, but works in the [Replay in Thread] or preview in the [Quote].

Steps to reproduce:

  1. http://localhost:3000/admin/settings/Message -> Markdown -> Markdown Parser -> Marked
  2. Open #General channel
  3. Paste correct code from https://docs.rocket.chat/contributors/how-can-i-help/documentation/markdown-styleguide#md005-no-inconsistent-indentation-for-list-items-at-the-same-level
* Item 1
    * Nested Item 1
    * Nested Item 2
    * Nested Item 3 --->Aligned
  1. Get broken nested items

Expected behavior:

Correct nested items, like in the 4.x.x

Actual behavior:

изображение изображение

Server Setup Information:

  • Version of Rocket.Chat Server: 5.0.5
  • Operating System: ubuntu
  • Deployment Method: docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 14.19.3 - x64
  • MongoDB Version: 5.0.11

Client Setup Information

  • Desktop App or Browser Version: app 3.8.8, firefox 103.0.2
  • Operating System: ubuntu 22.04

IgorOhrimenko avatar Aug 30 '22 12:08 IgorOhrimenko

Hi! We are changing our Parser, and some rough edges are still around.

This is kind of related to https://github.com/RocketChat/Rocket.Chat/issues/26642

Thanks for pointing this out!

dudanogueira avatar Sep 01 '22 18:09 dudanogueira

Also related to RocketChat/feature-requests#642

ulope avatar Nov 25 '22 17:11 ulope

Hi there,

I just started using RocketChat recently, I noticed the un-render issue with the "main" chat. I wonder if there is any update on this.

I'm also new to open-source development, if there is no one currently working on this, can I get some guidance on how to fix the un-render issue? I would like to work on this.

wwmogu avatar Aug 09 '23 07:08 wwmogu

The bug is still present in 6.2.10. Very annoying.

xmedeko avatar Sep 21 '23 15:09 xmedeko

Seems to be present in version 6.4 as well.

ostankin avatar Dec 22 '23 14:12 ostankin

It's not a bug, our message parser does not support this YET.

hugocostadev avatar Dec 22 '23 17:12 hugocostadev

Of course it’s a bug, for two reasons:

  • it used to work in the past
  • claiming markdown support but then not supporting basic syntax features is by definition a bug.

As for

our message parser does not support this YET

JFC, why do you need to reinvent markdown parsing? There are only an estimated 900 million parsers already.

ulope avatar Dec 24 '23 21:12 ulope

Still triggers me writing nested list in code block in 6.4. @hugocostadev , is there any ETA to fix that?

dusatvoj avatar Jan 11 '24 15:01 dusatvoj

It's not a bug, our message parser does not support this YET.

If not support this yet, mention it on official doc is better.

VergeDX avatar Jan 24 '24 09:01 VergeDX

I'm still running into this issue as of 6.9.2.

kuya1284 avatar Aug 01 '24 20:08 kuya1284