Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

Chore: Remove method calls - Stage 1

Open ggazzo opened this issue 3 years ago • 4 comments

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

ggazzo avatar Jul 06 '22 13:07 ggazzo

This pull request introduces 2 alerts when merging 89d173333a03ab805935999cbfffe7d727abc3ed into 45ee02dcb5d88d4b0ec6b3bb46bb4840c89faf08 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 26 '22 02:07 lgtm-com[bot]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Aug 08 '22 14:08 kodiakhq[bot]

Codecov Report

Merging #26149 (5df00d0) into develop (662ffb8) will decrease coverage by 0.20%. The diff coverage is 33.33%.

:exclamation: Current head 5df00d0 differs from pull request most recent head ceb9a7b. Consider uploading reports for the commit ceb9a7b to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26149      +/-   ##
===========================================
- Coverage    38.73%   38.52%   -0.21%     
===========================================
  Files          759      758       -1     
  Lines        18829    18816      -13     
  Branches      1459     1459              
===========================================
- Hits          7293     7249      -44     
- Misses       11319    11344      +25     
- Partials       217      223       +6     
Flag Coverage Δ
e2e 38.52% <33.33%> (-0.21%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 09 '22 14:08 codecov[bot]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Aug 09 '22 14:08 kodiakhq[bot]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Aug 10 '22 17:08 kodiakhq[bot]