Rocket.Chat
Rocket.Chat copied to clipboard
[FIX] Set default value "false" for global search.
Proposed changes (including videos or screenshots)
If we disable the "global search", then the "global search" checkbox removes from the UI. It's not what we want. I think, we should set the default to "false", because the default is to search inside the channel/dialog.
Issue(s)
Fixes: #20595
Steps to test or reproduce
- Enable the "global search" in admin settings.
- Go to channel or dialog.
- Use search and be happy.
I just did this in my local build because this has been so incredibly painful for us... Went to go push a PR and found this one. Can we get this merged, please?
Codecov Report
Merging #25568 (6be922c) into develop (12cd58e) will decrease coverage by
0.89%. The diff coverage is0.00%.
@@ Coverage Diff @@
## develop #25568 +/- ##
===========================================
- Coverage 41.25% 40.35% -0.90%
===========================================
Files 817 845 +28
Lines 17881 18378 +497
Branches 1988 2052 +64
===========================================
+ Hits 7376 7416 +40
- Misses 10220 10678 +458
+ Partials 285 284 -1
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 40.35% <0.00%> (-0.90%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
#21659