Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[IMPROVE] Pinned Messages in E2E rooms

Open yash-rajpal opened this issue 3 years ago • 1 comments

Proposed changes (including videos or screenshots)

Before

Screenshot 2022-04-27 at 11 08 59 PM

After

Screenshot 2022-04-27 at 11 09 15 PM

In Pinned Messages contextual bar - Screenshot 2022-04-27 at 11 29 25 PM

If we don't have E2EE keys - Screenshot 2022-04-27 at 11 08 44 PM

Issue(s)

Steps to test or reproduce

  • Create an end to end encrypted room.
  • Send message in the e2ee room and pin the message.
  • Pinned message should follow the e2ee rules.

Further comments

yash-rajpal avatar Apr 27 '22 18:04 yash-rajpal

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 53.70%. Comparing base (ff4e396) to head (832cd64).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #25325      +/-   ##
===========================================
- Coverage    55.59%   53.70%   -1.90%     
===========================================
  Files         2407     1112    -1295     
  Lines        52905    28341   -24564     
  Branches     10866     4000    -6866     
===========================================
- Hits         29415    15220   -14195     
+ Misses       20886    12291    -8595     
+ Partials      2604      830    -1774     
Flag Coverage Δ
e2e-api ?
unit 73.50% <ø> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 18 '22 17:08 codecov[bot]

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project
  • This PR has an invalid title

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Apr 12 '24 19:04 dionisio-bot[bot]

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project
  • This PR has an invalid title

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Apr 12 '24 19:04 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: 832cd6495072edc8b49c21aa33be6f8aa2dc6b51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 07 '24 11:05 changeset-bot[bot]

Closed in favor of - #32380

yash-rajpal avatar Jun 20 '24 13:06 yash-rajpal