[IMPROVE] Play selected notification sounds as preview while changing sound settings

Open try-catch-stack opened this issue 4 years ago • 4 comments

Proposed changes (including videos or screenshots)

Currently no sound plays while changing the notification sound settings or adjusting the volume which does not seem to be a good user experience as the user cannot preview the changes. This PR enables the user to listen the selected sound at the selected volume .

Check out this video for the proposed changes (Turn on the volume)

https://user-images.githubusercontent.com/77742477/149933395-b863bf2b-9f2b-448a-bfdc-3935db1b13fe.mp4

Issue(s)

Steps to test or reproduce

Further comments

Jan 18 '22 12:01 try-catch-stack

@dougfabris @sampaiodiego Can you please take a look ?

Jan 29 '22 16:01 try-catch-stack

Amazing work.🔥

Feb 11 '22 06:02 nishant23122000

@debdutdeb Can you please take a look at this again as it is open for a while now and haven't got any updates on it?

Feb 28 '22 15:02 try-catch-stack

Is this PR still actual for the community? I need this feature... And want to know what to expect

Nov 28 '22 12:11 adrianbarbe

Codecov Report

Merging #24205 (495af29) into develop (eac9d4f) will increase coverage by 11.39%. The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop   #24205       +/-   ##
============================================
+ Coverage    32.32%   43.72%   +11.39%     
============================================
  Files          626      791      +165     
  Lines        12481    15392     +2911     
  Branches      1836     2131      +295     
============================================
+ Hits          4035     6730     +2695     
- Misses        8248     8375      +127     
- Partials       198      287       +89

Flag	Coverage Δ
e2e	`43.69% <ø> (+11.36%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Feb 14 '23 03:02 codecov[bot]