[FIX] Archived channels reappearing permanently

Open im-adithya opened this issue 5 years ago • 4 comments

Proposed changes (including videos or screenshots)

I have included a check for archived in useEffect in the room list generator which was missing earlier.

Issue(s)

This PR closes #20065

Earlier

https://user-images.githubusercontent.com/64399555/106130968-1757ab00-6188-11eb-8d05-93f647b06457.mp4

Now

https://user-images.githubusercontent.com/64399555/106130977-19ba0500-6188-11eb-967c-3e5a67cb00bf.mp4

Jan 28 '21 11:01 im-adithya

Done! Please review it :)

Feb 12 '21 05:02 im-adithya

Done! Please review it :)

Still failing, please make sure to check if there are any ts or lint errors

Feb 25 '21 17:02 dougfabris

Done! Please review it :)

Still failing, please make sure to check if there are any ts or lint errors

The code which I have changed isn't causing the fail, it is some regex error (please see files changed section) How do I correct this?

Feb 25 '21 17:02 im-adithya

All committers have signed the CLA.

Dec 17 '21 17:12 CLAassistant

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@1f79964). Click here to learn what that means. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             develop   #20476   +/-   ##
==========================================
  Coverage           ?   42.08%           
==========================================
  Files              ?      813           
  Lines              ?    17843           
  Branches           ?     1989           
==========================================
  Hits               ?     7510           
  Misses             ?    10042           
  Partials           ?      291

Flag	Coverage Δ
e2e	`42.08% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Nov 22 '22 06:11 codecov[bot]