Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

Additional alias names of custom emojis not accepted anymore

Open frdmn opened this issue 5 years ago • 8 comments

Description:

According to our docs, it should be possible to add multiple alias names to custom emojis, separated by space character:

Enter a name for your emoji, add space separated list of the aliases for the emoji which can be entered to display the emoji in the chats

This does not seem to be working anymore, the space character will be replaced by a dash instead.

Steps to reproduce:

  1. Add a new custom emoji
  2. Give it multiple aliases, e.g. first second
  3. Hit save, see how the alias gets transformed into: first_second

Expected behavior:

It should separate the alias input by space, as stated in the docs, and accept multiple alias names.

Actual behavior:

Space character gets replaced by dash. Multiple aliases not possible.

Server Setup Information:

  • Version of Rocket.Chat Server: 3.4.0
  • Operating System: Linux
  • Deployment Method: Docker
  • Number of Running Instances: Docker
  • DB Replicaset Oplog: Yes
  • NodeJS Version: Docker
  • MongoDB Version: Docker

Additional context

Demo video

Bildschirmfoto 2020-07-15 um 10 45 26

frdmn avatar Jul 15 '20 08:07 frdmn

Seeing this too.

LeeThompson avatar Aug 09 '20 20:08 LeeThompson

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 09 '20 00:10 github-actions[bot]

Still broken in 3.7.0. If you use space it fills in an underscore.

LeeThompson avatar Oct 09 '20 20:10 LeeThompson

(This stat:stale thing because it hasn't been addressed or added to and then automatically closed is why these bugs stay.)

LeeThompson avatar Oct 09 '20 20:10 LeeThompson

I'm trying to resolve this in RocketChat/Rocket.Chat#23990; may I request a review?

RavuAlHemio avatar Feb 25 '22 08:02 RavuAlHemio

Today I investigated into several problems regarding custom emojis (cf. https://github.com/RocketChat/feature-requests/issues/807, https://github.com/RocketChat/Rocket.Chat/issues/26980).

In that process, I stumbled upon the problem described in this issue as well which still persists in Rocket.Chat 5.1.4.

paulchen avatar Sep 29 '22 18:09 paulchen

Hey, @dudanogueira I want to work on this Issue, Can you assign it to me?

codewithmitesh avatar Nov 26 '22 04:11 codewithmitesh

I‘ve already proposed a fix in RocketChat/Rocket.Chat#23990; unfortunately, it appears the dev team has not yet come around to reviewing it…

RavuAlHemio avatar Nov 26 '22 13:11 RavuAlHemio

@dudanogueira @ggazzo

Screenshot 2023-02-26 032734

https://github.com/RocketChat/Rocket.Chat/pull/28176

TafreedAhmad avatar Feb 26 '23 10:02 TafreedAhmad

I can't believe it's taken over 2 years...

LeeThompson avatar Feb 26 '23 21:02 LeeThompson

I can't believe it's taken over 2 years...

Especially since there is more than one PR containing a fix...

RavuAlHemio avatar Feb 26 '23 21:02 RavuAlHemio