Rocket.Chat.js.SDK icon indicating copy to clipboard operation
Rocket.Chat.js.SDK copied to clipboard

[FIX] Using inbuilt crypto instead of js-sha256

Open sidmohanty11 opened this issue 3 years ago • 2 comments

Fixes #154 Will resolve this issue also.

Testing

An example testing both modules gives the same result. So, it won't hamper anything. image

sidmohanty11 avatar Jul 09 '22 12:07 sidmohanty11

This pull request introduces 1 alert when merging 1e434a18e2274f0b8eac6be7d10d62ce1b82edd0 into 454b4ba784095057b8de862eb99340311b672e15 - view on LGTM.com

new alerts:

  • 1 for Use of password hash with insufficient computational effort

lgtm-com[bot] avatar Jul 09 '22 12:07 lgtm-com[bot]

@sampaiodiego @djorkaeffalexandre please take a look. This resolves an important error message.

sidmohanty11 avatar Aug 10 '22 14:08 sidmohanty11