Rocket.Chat.iOS icon indicating copy to clipboard operation
Rocket.Chat.iOS copied to clipboard

[WIP] [NEW] Project 03 - Changing, searching and adding channels VoiceOver accessible

Open rudrankriyam opened this issue 6 years ago • 1 comments

@RocketChat/ios

  • [x] Clicking on a room reads the WHOLE message, instead of an excerpt of the message.
  • [x] Sorting by activity needs a hint regarding double tapping to open the options.
  • [x] “New Channel” Button is not accessible. It is described in VoiceOver as a “Button” and should have an accessibilityLabel = “Create New Channel”
  • [x] “Public Channel” and “Read only channel” text field and the switch toggle should be read as one.
  • [x] After creating a channel, VoiceOver describes the button as “Create Dim”, which should be labelled as “Channel created successfully.” Edit - Create Dim means that it is in working state. After the channel is created, it goes to the channel itself.
  • [x] The cross button is described in VoiceOver as “Stop” button, which needs to be named as “Close” button.
  • [x] “Share” button needs to be associated with UIAccessibilityTraits.button.
  • [x] “Favorite” button is not accessible. It is described in VoiceOver as a “Button” and should have an accessibilityLabel = “Star”
  • [x] The “Video Call” button is not accessible. It is described in VoiceOver as “User.Detail Video Call”, which should have an accessibilityLabel = “Video Call”.
  • [x] Receive Notification and Show Unread Counter text field and the switch toggle should be read as one.
  • [x] The VoiceOver should describe the cell as one unit, instead of two different accessibility elements.

rudrankriyam avatar Aug 19 '19 08:08 rudrankriyam

Codecov Report

Merging #2751 into develop will decrease coverage by 0.03%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2751      +/-   ##
===========================================
- Coverage     46.1%   46.07%   -0.04%     
===========================================
  Files          626      626              
  Lines        28938    28958      +20     
===========================================
- Hits         13343    13341       -2     
- Misses       15595    15617      +22
Impacted Files Coverage Δ
...t/Views/Subscriptions/SubscriptionsTitleView.swift 41.66% <ø> (-3.08%) :arrow_down:
...at/Views/Cells/Subscription/SubscriptionCell.swift 0% <0%> (ø) :arrow_up:
...ontrollers/Chat/ChannelActionsViewController.swift 0% <0%> (ø) :arrow_up:
...iews/Cells/Subscription/BaseSubscriptionCell.swift 0% <0%> (ø) :arrow_up:
...trollers/Subscriptions/NewRoomViewController.swift 19.56% <0%> (-0.29%) :arrow_down:
...ubscriptionsList/SubscriptionsViewController.swift 1.41% <0%> (-0.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f5ad00...c690c33. Read the comment docs.

codecov[bot] avatar Aug 19 '19 08:08 codecov[bot]