Rocket.Chat.iOS
Rocket.Chat.iOS copied to clipboard
[NEW] Project 09 - Recording and sending audio VoiceOver accessible
@RocketChat/ios
- [x] The micButton is described in VoiceOver as “Mic Button” which needs to be assigned an accessibilityLabel = “Record Audio”
- [x] The sendButton is described in VoiceOver as “Red Mic Button” which needs to be assigned an accessibilityLabel = “Stop recording”
- [x] The timeLabel is described in VoiceOver as “zero three” which needs to be accessible as “Duration three seconds.” This will be accomplished using DateComponentsFormatter.
- [x] “Swipe to cancel” button will be enabled for a left swipe using UIAccessibilityTraitAllowsDirectInteraction .
The following buttons are described in VoiceOver with a redundant “Button”
- [x] The playButton which needs to be assigned an accessibilityLabel = “Play” instead of “Play Button” ✅
- [x] The sendButton which needs to be assigned an accessibilityLabel = “Send” instead of “Send Button” ✅
- [x] The discardButton which needs to be assigned an accessibilityLabel = “Discard” instead of “Discard Button” ✅
- [x] The sendButton sometimes is described in VoiceOver as “Red Mic Button” ✅
- [x] The timeLabel is described in VoiceOver as “zero two” which needs to be accessible as “Duration two seconds.” This will be accomplished using DateComponentsFormatter.
- [x] Currently the Slider is described in VoiceOver as “Zero percent. Adjustable. Swipe up or down with one finger to adjust the value”. It should be rather “Recording position zero seconds of two seconds. Adjustable.”
- [x] Setting UIAccessibilityTraits.adjustable for the AudioView.
- [x] The playButton is described in VoiceOver as “Player Play” which needs to be assigned an accessibilityLabel = “Play Audio” ✅
I hid the accessibilityElements wherever applicable so it provides a smooth VoiceOver experience.
Codecov Report
Merging #2748 into develop will decrease coverage by
1.06%. The diff coverage is0%.
@@ Coverage Diff @@
## develop #2748 +/- ##
===========================================
- Coverage 46.1% 45.04% -1.07%
===========================================
Files 626 626
Lines 28938 28953 +15
===========================================
- Hits 13343 13042 -301
- Misses 15595 15911 +316
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...t.Chat/Views/Cells/Chat/ChatMessageAudioView.swift | 0% <0%> (ø) |
:arrow_up: |
| ...Chat/Controllers/Chat/MessagesViewController.swift | 1.37% <0%> (-42.87%) |
:arrow_down: |
| ...ews/Chat/New Chat/Cells/BaseAudioMessageCell.swift | 0% <0%> (ø) |
:arrow_up: |
| Rocket.Chat/Helpers/RCDateFormatter.swift | 0% <0%> (ø) |
:arrow_up: |
| Rocket.Chat/Views/Base/BaseNavigationBar.swift | 0% <0%> (-100%) |
:arrow_down: |
| Rocket.Chat/Views/Chat/ChatAnnouncementView.swift | 0% <0%> (-83.34%) |
:arrow_down: |
| ...ontrollers/Chat/MessagesViewControllerTyping.swift | 0% <0%> (-77.78%) |
:arrow_down: |
| ...ntrollers/Chat/MessagesViewControllerJoining.swift | 0% <0%> (-71.74%) |
:arrow_down: |
| ...trollers/Chat/MessagesViewControllerDrafting.swift | 20% <0%> (-60%) |
:arrow_down: |
| ...Views/Cells/Subscription/ChatPreviewModeView.swift | 0% <0%> (-43.75%) |
:arrow_down: |
| ... and 13 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 2f5ad00...05aa00c. Read the comment docs.
Awesome work. Thank you!