Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard
verified publisher icon RocketChat

Fix - Prevent Updating Name, Username, Email, and New Password with Empty/Whitespace Values

Open anirbanpaulcom opened this issue 2 years ago • 3 comments

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] Improvement (non-breaking change which improves a current function)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [ ] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added necessary documentation (if applicable)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

anirbanpaulcom avatar Feb 06 '24 15:02 anirbanpaulcom

Your PR fixes an issue, but it should be using react-hook-form

https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/aa3938a2a46a3694f874350c6aaf73062a114e3c/app/views/CreateChannelView/index.tsx#L86

Can you migrate this component?

@diegolmello Can you please tell me how to migrate it because the React Hook 'useForm' cannot be called in a class component, or should I wrap it?

anirbanpaulcom avatar Feb 16 '24 14:02 anirbanpaulcom

Hey @anirbanpaulcom. Can you migrate the component to hooks on another PR and then use react-hook-form? Thanks!

diegolmello avatar Feb 16 '24 15:02 diegolmello

Hey @anirbanpaulcom. Can you migrate the component to hooks on another PR and then use react-hook-form? Thanks!

@diegolmello , Please take a look, PR : #5646

anirbanpaulcom avatar Apr 08 '24 17:04 anirbanpaulcom