Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

[FEATURE] Show Thumbnails/Preview for Uploaded Videos

Open pratyaksh123 opened this issue 5 years ago • 6 comments

Description:

Currently there is no thumbnail displayed for an uploaded video.

WhatsApp Image 2020-12-27 at 4 17 52 AM

Steps to reproduce:

  1. Upload a video

Expected behavior:

Thumbnails should show up, like this

WhatsApp Image 2020-12-27 at 4 16 24 AM

pratyaksh123 avatar Dec 26 '20 22:12 pratyaksh123

I am working on this feature, will soon push a PR for this 🚀
Currently, the thumbnails correctly show up ( like that in the actual behavior image ) but I feel the load time can be significantly improved, working on that.

pratyaksh123 avatar Dec 26 '20 22:12 pratyaksh123

@pratyaksh123 Awesome!

diegolmello avatar Jan 04 '21 12:01 diegolmello

Hey, i see that this issue still persists despite having multiple PRs . I can take the current PRs ,see why they failed and make a new one.

atulsingh98 avatar Jan 05 '24 06:01 atulsingh98

I can take the current PRs ,see why they failed and make a new one.

👍🏾

dnlsilva avatar Jan 05 '24 12:01 dnlsilva

Hey, i see that this issue still persists despite having multiple PRs . I can take the current PRs ,see why they failed and make a new one.

To be transparent, we tried some approaches using expo-video-thumbnails, but this directly affected the app's performance. During your tests, try with more than 3 or 4 videos rendering in parallel. Besides testing with the thumbnail, you must properly test the performance. It's not a problem if the thumbnail at the first image getter takes some seconds, but this time delay can't affect navigation, scrolling of the message list, or any animations. So, taking into consideration all the steps, this isn't a simple solution.

reinaldonetof avatar Jan 05 '24 14:01 reinaldonetof

ahh i see. looks like you guys are planning to generate thumbnails on the backend, even i think its better to generate in the backend because of tools like ffmpeg. I'll explore the feature with other libraries on the frontend in my free time and let you guys know if i can get it working.

atulsingh98 avatar Jan 05 '24 17:01 atulsingh98