Rocket.Chat.Apps-engine icon indicating copy to clipboard operation
Rocket.Chat.Apps-engine copied to clipboard

[IMPROVE] Rewrite gulpfile in typescript

Open aditya-mitra opened this issue 4 years ago • 2 comments

What? :boat:

Closes #393

  1. Added: -gulpfile.ts,
  • npm type definitions for gulp, gulp-bump and gulp-sourcemaps
  • gupfile.d.ts for those modules which did not have type definitions found in npm
  1. Updated:
  1. Removed:
  • gulpfile.js

Why? :thinking:

Since most of the codebase of Rocket.Chat.Apps-engine is written in typescript, it would be nicer if we could write gulpfile also in typescript. smiley

Links :earth_americas:

Issue #393

PS :eyes:

aditya-mitra avatar Mar 11 '21 12:03 aditya-mitra

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 11 '21 12:03 CLAassistant

Hi, The compilation is passing locally but failing on CircleCI. (I even tried this on a fresh GitPod instance and it was working)

image

What is the reason for this problem?

aditya-mitra avatar Mar 11 '21 13:03 aditya-mitra