EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

Fix: Alt + Arrow Key Shortcuts Not Functioning in Message Navigation

Open KrishnaShuk opened this issue 11 months ago • 3 comments

This PR addresses the issue where Alt + Left Arrow, Alt + Right Arrow, Alt + Up Arrow, and Alt + Down Arrow shortcuts were not functioning as expected for message navigation.

Acceptance Criteria fulfillment

  • [x] Ensured that the event listeners correctly capture Alt + Arrow Key inputs.
  • [x] Tested across different browsers to confirm the fix.

Fixes #989

Video/Screenshots

Screencast from 2025-02-15 19-43-29.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

KrishnaShuk avatar Feb 15 '25 14:02 KrishnaShuk

@KrishnaShuk Please use 'Prettier' formatter to pass the lint test

Spiral-Memory avatar Mar 01 '25 10:03 Spiral-Memory

@Spiral-Memory I have made the required changes.

KrishnaShuk avatar Mar 02 '25 07:03 KrishnaShuk

Hi! The PR has been approved, but it's currently blocked by pending workflow approvals. Could you please approve the workflows? Thanks!

KrishnaShuk avatar Apr 08 '25 18:04 KrishnaShuk

Lint check is still failed

Spiral-Memory avatar Apr 08 '25 18:04 Spiral-Memory

I have made some changes in my latest commit and this passes the lint test. Screenshot from 2025-04-10 14-31-46

KrishnaShuk avatar Apr 10 '25 10:04 KrishnaShuk