EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

fix: Search Messages crashes on 429 from server #974

Open Abbas-Askari opened this issue 11 months ago • 1 comments

Fixes #974 by introducing a timeout (20s) on a 429 by the server and then trying again. In this period (timeouts and fetches) a Throbber (loading component) is rendered.

Video/Screenshots

Screencast from 2025-02-11 00-04-16.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-975 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

Abbas-Askari avatar Feb 10 '25 19:02 Abbas-Askari

There is one possible way of knowing the exact time to wait, But that is very messy and RC main dosen't use it as well. It will require the modification of EmbeddedChatApi. Instead of sending to chat.search we would send to rocketchatSearch.search which gives the exact milliseconds to wait. But its usage is completely different.

Abbas-Askari avatar Feb 10 '25 19:02 Abbas-Askari