EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

feat: Added a conditional check before showing Avatar in attachments

Open thepiyush-303 opened this issue 1 year ago • 4 comments

Brief Title

Acceptance Criteria fulfillment

  • [x] Now when avatar is set to false inside addons then attached items's docs not show avatar

Fixes #787

Video/Screenshots

Screencast from 2025-01-04 01-05-18.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-788 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

thepiyush-303 avatar Jan 03 '25 17:01 thepiyush-303

Hey @thepiyush-303, I noticed that the video you uploaded might not correspond to the changes in this PR. Could you update the PR description with:

  1. A highlight of the changes made.
  2. The correct video showcasing the implemented fixes.
  3. Also link your PR with the issue

abirc8010 avatar Jan 03 '25 19:01 abirc8010

Hey @thepiyush-303, I noticed that the video you uploaded might not correspond to the changes in this PR. Could you update the PR description with:

1. A highlight of the changes made.

2. The correct video showcasing the implemented fixes.

3. Also link your PR with the issue

Thanks, @abirc8010 for letting me know it was showing now i update it. also i see a minor css issue i'll commit it soon

thepiyush-303 avatar Jan 03 '25 19:01 thepiyush-303

Update the video, i can see some text overlaps

Spiral-Memory avatar Jan 27 '25 17:01 Spiral-Memory

@Spiral-Memory It is fixed in my last commit.

https://github.com/user-attachments/assets/b39321e0-e278-48f3-9009-6bd4b954b378

thepiyush-303 avatar Jan 27 '25 18:01 thepiyush-303