EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

[Feat] : Deploy PR Previews to GitHub Pages

Open devanshkansagra opened this issue 1 year ago • 7 comments

As an EmbeddedChat developer

I need to: Deploy the preview of the changes made in a pull request to Github Pages

So That: Maintainers and other users can get to see and review the output before it gets merged

Acceptance Criteria

  • [ ] Deploy the changes made in pull request to Github pages

Rough Example Make it something like this: https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr-number>/

devanshkansagra avatar Aug 13 '24 15:08 devanshkansagra

Hey @sidmohanty11 and @Spiral-Memory, I am working on this !

devanshkansagra avatar Aug 13 '24 15:08 devanshkansagra

Sure @devanshkansagra

Spiral-Memory avatar Aug 13 '24 15:08 Spiral-Memory

Hey @Spiral-Memory, which projects of monrepo do we have to add in this?

devanshkansagra avatar Aug 14 '24 17:08 devanshkansagra

For all (but for a start, you can test for Embedded Chat (as that's the most important one)

Spiral-Memory avatar Aug 14 '24 17:08 Spiral-Memory

No I am talking about, do I add react, layout-editor, ui-elements?? or all??

devanshkansagra avatar Aug 14 '24 17:08 devanshkansagra

All (for testing, react is fine, but we need all)

Spiral-Memory avatar Aug 14 '24 17:08 Spiral-Memory

ok

devanshkansagra avatar Aug 14 '24 18:08 devanshkansagra