RocketChat
Fixed UI Inconsistencies while quoting messages
Acceptance Criteria fulfillment
- [x] Added support for quoting different types of attachements
- [x] Implemented displaying of attachement while quoting
- [x] Fix recursive quoting
- [x] Fix design of quoted message in curved variants
Fixes #563
Video/Screenshots
Screencast from 2024-07-14 16-41-33.webm
Hey @devanshkansagra,
Thanks for the contribution.
While quoting messages, there's a sideline that appears and quotes the message. It seems like you simply removed it, which shouldn't be the case. Please also try it in Storybook so that we can see the changes across all design variants. It must work properly in all variants. Additionally, I don't think it's a good idea to show thumbnails in "QuoteBox." Images look fine, but video and audio appear way too big.
Hey maintainers, I have fixed the issue of recursive quoting, but I got stucked at styling of recursive quoting of messages in curved variants, I have explored a lot, but I didn't get any clue. So anyone could please suggest me, what kind of design improvements I need to make to fix this
This is the design issue in curved variant
It looks proper in other variants (Ex StormySeas)
Hey @devanshkansagra It looks good !
Let me know the exact problem you are facing in fixing the design in curved variant as well
Hey @devanshkansagra It looks good !
Let me know the exact problem you are facing in fixing the design in curved variant as well
Most basically the improper alignment in curved variants
Also please update the video with your latest changes
Updated the video
Also please update the video with your latest changes
Updated the video
Checked your video, Great work!
Can we fix this as well before fixing for the curved variant, that it should display the actual message here instead of msg link:
Also, in recursive quoting, the video / image is not visible, I know you have let me know about it that even with main RC it doesn't work, but it would be great if you find a fix for that as well if possible.
Thanks!
Also please update the video with your latest changes
Updated the video
Checked your video, Great work!
Can we fix this as well before fixing for the curved variant, that it should display the actual message here instead of msg link:
Also, in recursive quoting, the video / image is not visible, I know you have let me know about it that even with main RC it doesn't work, but it would be great if you find a fix for that as well if possible.
Thanks!
will fix and make the recursive quote preview look like RC
Hey maintainers, Can you review my pull request? So that I can follow up any changes if needed
Hey @devanshkansagra
I watched your video, it's looking good ! However in recursive quoting, attachment is not getting displayed right ?
I'll review the code to see if it's not breaking anything..
Thanks a lot for the contribution !
Hey @devanshkansagra
I watched your video, it's looking good ! However in recursive quoting, attachment is not getting displayed right ?
I'll review the code to see if it's not breaking anything..
Thanks a lot for the contribution !
This issue is there with the main RC, hence it is not able to display the attachment while recursive quoting
Hey @devanshkansagra
I watched your video, it's looking good ! However in recursive quoting, attachment is not getting displayed right ?
I'll review the code to see if it's not breaking anything..
Thanks a lot for the contribution !
This issue is there with the main RC, hence it is not able to display the attachment while recursive quoting
Ohh Okay !
Let me see it, I'll let you know
Thank you for contribution @devanshkansagra Merging it for testing, will revert back if there are issues