Apps.Whiteboard icon indicating copy to clipboard operation
Apps.Whiteboard copied to clipboard

feat: adding search command

Open brf153 opened this issue 2 years ago • 8 comments

brf153 avatar Jan 06 '24 10:01 brf153

@CulturalProfessor for search functionality, should I add the feature that when we are searching the board, we render a new board with searched board's data and configurations and delete the initial board? Which means that lets say I created an initial board with the name bhandari. Then someone searches for that board and we render a new board which contains all the data of the board with the name bhandari and delete the board which was initially created with the name bhandari. The newly rendered board wilil look and work in the same way as that of the initial board. It is just that we would not have multiple boards in the room which searching for a board.

brf153 avatar Jan 06 '24 15:01 brf153

@CulturalProfessor for search functionality, should I add the feature that when we are searching the board, we render a new board with searched board's data and configurations and delete the initial board? Which means that lets say I created an initial board with the name bhandari. Then someone searches for that board and we render a new board which contains all the data of the board with the name bhandari and delete the board which was initially created with the name bhandari. The newly rendered board wilil look and work in the same way as that of the initial board. It is just that we would not have multiple boards in the room which searching for a board.

yeah but in this case we're deleting original message along with any critical info in it maybe in a form of thread or reactions .

So a better way might be if we can quote the original message as a notification so user can jump back to it

CulturalProfessor avatar Jan 06 '24 15:01 CulturalProfessor

Oki will quote the message

brf153 avatar Jan 06 '24 15:01 brf153

@CulturalProfessor please can you tell me how to quote a message? I am not being able to find the function.

brf153 avatar Jan 07 '24 14:01 brf153

@CulturalProfessor, I think this is a good approach.

https://github.com/RocketChat/Apps.Whiteboard/assets/107868772/19d319d5-698f-465e-b981-d2883781c4ea

brf153 avatar Jan 14 '24 06:01 brf153

@CulturalProfessor, I think this is a good approach.

WhatsApp.Video.2024-01-14.at.11.39.37.mp4

Hey @brf153 it seems a good approach see if we can open the button link in same tab

CulturalProfessor avatar Jan 17 '24 20:01 CulturalProfessor

@CulturalProfessor actually I checked it. One way that I got is to refresh the page when the user clicks on the board. I don't think it is a good approach.

I think this approach is better because lets say that if the board is way up in the room then the user might have to scroll down again or refresh or do something equivalent to come back to the latest message. But with this approach the user can directly access the board. After accessing the board he can simply close the tab and he would see the latest message.

brf153 avatar Jan 18 '24 02:01 brf153

@CulturalProfessor Should I make any additional modifications to this pull request? Would you like me to alter the approach?

brf153 avatar Jan 27 '24 07:01 brf153