Apps.Github22 icon indicating copy to clipboard operation
Apps.Github22 copied to clipboard

Application Crashing on entering wrong pull request number

Open ayush3160 opened this issue 2 years ago • 0 comments

Description:

Application is crashing when entering wrong pull request number to view the Pull request Details modal. If a user is entering wrong pull request number or invalid pull request in the /github Username/RepositoryName pulls pullNumber command then the Rocket.Chat server is crashing.

Steps to reproduce:

  1. Enter the command /github Username/RepositoryName pulls pullNumber with some wrong PR number.
  2. Notice application is crashing

Expected behavior:

A invalid-message modal should open in case of any wrong input.

Additional context

https://user-images.githubusercontent.com/89914602/229296282-0b8a0c66-8776-42ec-bb18-e10d3411c60f.mp4

ayush3160 avatar Apr 01 '23 14:04 ayush3160