Apps.Github22 icon indicating copy to clipboard operation
Apps.Github22 copied to clipboard

[FEAT] Send Notification with `Login` ActionBlock When User Not logged In

Open Nabhag8848 opened this issue 3 years ago • 4 comments

Why do we need this ?

As a GitHub App developer

I need to:

  • Alter/Add Extra information to the Block Notification Send when user runs commands (list mentioned) which needs authentication while not being loggedin.

Command List:

- View your GitHub Profile and Issues -> /github me
- View/Add/Delete/Update Repository Subscriptions -> /github subscribe
- Subscribe to all repository events -> /github Username/RepositoryName subscribe
- Unsubscribe to all repository events -> /github Username/RepositoryName unsubscribe
- Add New Issues to GitHub Repository -> /github issue
- Assign and Share Issues -> /github issues
  • So Currently when we run above command for eg for subscribing events we get Notification that Login to subscribe to repository events ! /github login but what we want is and will more helpful: We send Login ActionButton attaching to that same Block while having the Message You must be LoggedIn to subscribe repository events. Login to Github.

So That: We will save the key strokes for users to not run command /github login

Glimpses of what should look like:

LoginFeatExtend

Acceptance Criteria

  • [ ] Alter and Add to same Notify Block with LoginButtons for all commands mention

Further Comments / References

  • Also to Note we will have different messages the one that i mention was just for the subscribe event.
  • To note we also have ActionsButtons within Modal which needs authentications dont forget to look for same.

Additional comments

  • Apart from that we have one know bug (when writing this issue): When we run /github Username/RepositoryName subscribe without loggedin we ain't getting any message if we are not loggedIn. which has/ have been fixed #63. which currently provides the simple loginInfo make sure to change it when merging this.

Nabhag8848 avatar Feb 15 '23 07:02 Nabhag8848

Hey, @samad-yar-khan can you have a look at this, do we need this feat?

Nabhag8848 avatar Feb 26 '23 07:02 Nabhag8848

Hey @Nabhag8848 Seems like a good thing to have ! thanks for pointing this suggestion

samad-yar-khan avatar Mar 13 '23 21:03 samad-yar-khan

Note:

  • Any PRs to this issue will needs to be merge after #63. (Check additional comments above)

Nabhag8848 avatar Mar 14 '23 08:03 Nabhag8848

Hiya again @Nabhag8848 @samad-yar-khan! Created a PR to fix this issue, kindly review.

Prince-Mendiratta avatar Mar 26 '23 22:03 Prince-Mendiratta