creator-docs icon indicating copy to clipboard operation
creator-docs copied to clipboard

Add missing AssetTypes

Open karl-police opened this issue 1 year ago • 3 comments

Changes

This adds missing AssetTypes (probably needs to be updated internally on the API definition)

These informations come from the Webpack of Roblox and a few AssetIds that confirm the same values.

This is also good to update, because "CodeSnippets" is definitely gonna appear somewhere around the MarketplaceService in the future.

Checks

By submitting your pull request for review, you agree to the following:

  • [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • [x] To the best of my knowledge, all proposed changes are accurate.

karl-police avatar Apr 20 '24 17:04 karl-police

I have no clue what the bot is asking me to do

karl-police avatar Apr 20 '24 17:04 karl-police

Hi @karl-police , Could you please provide more context on where you gathered all of these additions? When using Studio's autocomplete (i.e. type Enum.AssetType.[], none of these additions appears in the suggestion popup.

As for what the bot is saying, it basically means that enums need to be edited at the source, and only the summary/description of existing enum items can be modified to maintain sync integrity between engine/docs.

IgnisRBX avatar May 06 '24 17:05 IgnisRBX

Hi @karl-police , Could you please provide more context on where you gathered all of these additions? When using Studio's autocomplete (i.e. type Enum.AssetType.[], none of these additions appears in the suggestion popup.

As for what the bot is saying, it basically means that enums need to be edited at the source, and only the summary/description of existing enum items can be modified to maintain sync integrity between engine/docs.

Two ways. One was by using Asset Ids and comparing them with the webpack resources from Roblox.

Then I compared them with GitHub Repositories, no clue where they got the IDs from, maybe there's some stuff I missed out in webpack. The repositories were found purely by searching the Enum Name terms.

 

SolidModel (39): https://economy.roblox.com/v2/assets/2101493884/details

LocalizationTableManifest (59): https://economy.roblox.com/v2/assets/17018879636/details

TexturePack (63): https://economy.roblox.com/v2/assets/17018879391/details

MeshHiddenSurfaceRemoval (75): https://economy.roblox.com/v2/assets/17028878663/details

 

It's not incorrect them not appearing in Enum.AssetType. It looks like internally they were not added onto that Enum list, so they're missing.

 

I do wonder though what the asset type HTML is used for.

karl-police avatar May 06 '24 22:05 karl-police

This pull request has been inactive for 14 days. If it remains inactive for another 7 days, it will close. Please update or comment on this pull request to keep it open. 🙏

github-actions[bot] avatar May 21 '24 08:05 github-actions[bot]

This pull request has been inactive for 14 days. If it remains inactive for another 7 days, it will close. Please update or comment on this pull request to keep it open. 🙏

noooooo

karl-police avatar May 21 '24 11:05 karl-police

Apologies for the delay... I'm looking into this further. :)

IgnisRBX avatar May 31 '24 15:05 IgnisRBX

Hi @karl-police, I explored this further and found that at least some of these are unlisted due to deprecation, non-use, no intention for creator usage, original usage replaced by another asset type, or very limited usage (i.e. perhaps one item on the entire platform). These include:

  • HTML and Text
  • Avatar
  • GroupEmblem
  • Arms and Legs
  • App
  • Code
  • CodeSnippet

I'm exploring the others and I'll respond when I discover more info on them.

IgnisRBX avatar Jun 18 '24 15:06 IgnisRBX

Hi @karl-police, I checked into the other items that aren't listed, and for various reasons, they also aren't intended for creator usage. If these types are, at some point, intended for creator usage, we'll surface them in the documentation. Apologies for the long run-around and delay on this; we appreciate you bringing it to our attention.

IgnisRBX avatar Jun 21 '24 19:06 IgnisRBX

Hi @karl-police, I checked into the other items that aren't listed, and for various reasons, they also aren't intended for creator usage. If these types are, at some point, intended for creator usage, we'll surface them in the documentation. Apologies for the long run-around and delay on this; we appreciate you bringing it to our attention.

Alright 👍

karl-police avatar Jun 27 '24 12:06 karl-police