pyright-python icon indicating copy to clipboard operation
pyright-python copied to clipboard

Prebuilt node install fails - v22.0.0 not found

Open monkpit opened this issue 1 year ago • 2 comments

Moved from https://github.com/microsoft/pyright/issues/7762

Using pyright v1.1.360 has started failing for me today in my CI pipeline with the following error:

* Install prebuilt node (22.0.0) .Failed to download from https://unofficial-builds.nodejs.org/download/release/v22.0.0/node-v22.0.0-linux-x64-musl.tar.gz When I follow the link, it indeed does not exist. It looks like this version of node was released today

I am caching pyright in a private repository to avoid issues like this, but I can't avoid this one since it seems to be done at runtime.

For reference, the command in my CI environment is: pyright . --venvpath <path>, and pyright is installed in a previous step using poetry.

Can anyone reproduce this? Are there any workarounds? Can I override the version of node that pyright is asking for via a flag?

EDIT: My current workaround was to add node to my CI build docker image, which is good enough for me, for now.

monkpit avatar Apr 24 '24 21:04 monkpit

I'll close this issue since the build has now been populated (the link in my original post now DOES exist after 1 day), however this issue will probably come up again next time a new version is released. It might make sense to add some logic to gracefully retry another version when the download link 404s.

monkpit avatar Apr 25 '24 15:04 monkpit

Reopening this issue since it’s happening again today with 22.3.0, and should be resolved so this doesn’t crop up again with each node release.

monkpit avatar Jun 11 '24 20:06 monkpit

I'm going to close this issue as the next release will add nodejs-wheel as an alternative to nodeenv which should be more reliable.

You can try it out today with

python -m pip install 'git+https://github.com/RobertCraigie/pyright-python.git#egg=pyright[nodejs]'

When released, it will be

pip install pyright[nodejs]

Please let me know if you run into any issues with this new setup.

RobertCraigie avatar Sep 22 '24 20:09 RobertCraigie