pyright-python icon indicating copy to clipboard operation
pyright-python copied to clipboard

Fix calling of npx

Open bustbr opened this issue 4 years ago • 2 comments

According to the NPX documentation for the syntax we're using the -- is not supported (or rather has no special meaning) and everything (including any --) after the package name will be passed on to the command. This PR tries to fix #11 by simply dropping the injected --.

We also add a unit test for building the npx command.

bustbr avatar Nov 25 '21 16:11 bustbr

Codecov Report

Merging #18 (51196b0) into main (e3a8978) will increase coverage by 0.69%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   74.64%   75.34%   +0.69%     
==========================================
  Files          12       13       +1     
  Lines         284      292       +8     
==========================================
+ Hits          212      220       +8     
  Misses         72       72              
Impacted Files Coverage Δ
pyright/cli.py 92.85% <100.00%> (+0.54%) :arrow_up:
tests/test_cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3a8978...51196b0. Read the comment docs.

codecov[bot] avatar Nov 25 '21 16:11 codecov[bot]

Going to add support for windows before merging this PR, thanks for your contributions!

RobertCraigie avatar Nov 29 '21 20:11 RobertCraigie