DropKick icon indicating copy to clipboard operation
DropKick copied to clipboard

Bubble Option not triggering change on the native select

Open janwidmer opened this issue 7 years ago • 1 comments

Version of Dropkick: 2.2.4

Expected Behaviour

Setting the option bubble to true triggers a change event on the native select. (Is that actually the exptected behaviour? Based on this Bugticket https://github.com/Robdel12/DropKick/issues/303 and the docs (http://dropkickjs.com/docs/#bubble) thats how I understood it..)

Actual Behaviour

The native select does not receive a change event. I am using Dropkick in combination with the validation library parsleyjs. Because the native select does not receive the change event, the validation message does not go away.

Steps To Reproduce:

  1. Open below codepen
  2. Click submit Button which triggers the validation on the dropdown
  3. Choose an option from the dropdown
  4. The validation message should disappear
  5. Because of no change event on the native select, the validation message stays ()
  6. (Correct behaviour can be seen by turning of the init of dropkick)

JSBin / Example repo / Failing test:

Codepen to see the behaviour: https://codepen.io/janwidmer/pen/NezQdE

janwidmer avatar Jan 08 '19 19:01 janwidmer

The "problem" is probably the combination of both plugins. Setting the data attribute data-parsley-trigger-after-failure="change" on the select makes it work correctly, which is kinda ironic since the native select does not seem to get a change event according to the codepen.. The default value of that data attribute is input which should according to mdn also include the change event..

janwidmer avatar Jan 08 '19 19:01 janwidmer