HomeAssistant-GreeClimateComponent icon indicating copy to clipboard operation
HomeAssistant-GreeClimateComponent copied to clipboard
verified publisher icon RobHofmann

[DNM] Gree Integration rewrite

Open p-monteiro opened this issue 4 months ago • 29 comments

[DO NOT MERGE]

⚠️ATTENTION ⚠

This PR changes the domain of the integration, so current users will lose their device configs! The config schema also changed, so verify your YAML if you use it to configure the devices.

This PR introduces a rewrite of this integration. The main goal of this was to better align the integration with the Home Assistant (HA) development workflow with two main changes:

  • Completely separate device API code from HA code
  • Align with code style guidelines (mainly Ruff code formatting and full typing)

Other changes that are present in this PR:

  • Async device communication
  • Use a device coordinator to fetch data from the device
  • Device Features are user-selectable since the Gree API does not provide a reliable method of getting them
  • Improvements to entity creation and config flow with better errors and organization
  • Gree API functions are better structured and clearer to understand the logic, which is also reused when possible
  • Gree API is fully declarative, no string guessing
  • Gree API now provides a GreeDevice object to handle device logic
  • Implement Auto Encryption version
  • Expose entity restore behavior as a configuration
  • Properly allow to reconfigure a config entry (including device connection, useful for when a device changes IP)
  • Support for individual device removal
  • RestoreEntity support in ClimateEntity
  • Exposed all device sensors as entities
  • Allow to set the device temperature units (shown on the device display)

I want full feature parity with the current integration and iron out some bugs before this is ready to merge (if you so wish). Currently missing and wishlist:

  • [Bug] Broken VRF Device Status

As you can see, there are a lot of changes, and I understand if this does not go through as is. I am creating the PR mainly to gather feedback and track progress since most features are now present in this PR. Don't treat this PR as blocking. I am tracking new changes and integrating them as they are committed.

Also, since this is a big rewrite, I wonder if we should use it to bump the major version (4?) and possibly change the domain to not replace the official integration (as I saw in the bug reports that it might impose some problems).

p-monteiro avatar Sep 23 '25 20:09 p-monteiro

@RobHofmann I was adding the temperature step back, but I'm not sure of its utility. Is there any device that accepts non-integer ºC/ºF?

p-monteiro avatar Sep 24 '25 21:09 p-monteiro

@p-monteiro The temperature step should not be in the configuration entities anyways, it should be in the climate options. That was a mistake on my part.

domialex avatar Sep 26 '25 18:09 domialex

Hi @domialex, that's fine. I'm more interested in the real use case for it. Should it be locked to integers? I don't think any device supports half degrees or even 0.1 steps, as is the lower limit for the current slider...

p-monteiro avatar Sep 26 '25 18:09 p-monteiro

@p-monteiro I'm getting an error when trying to auto discovery (vrf).

This error originated from a custom integration.

Logger: custom_components.gree.gree_api
Source: custom_components/gree/gree_api.py:869
integration: Gree A/C (documentation)
First occurred: 1:44:19 PM (3 occurrences)
Last logged: 3:04:12 PM

Failed to fetch sub-devices
Traceback (most recent call last):
  File "/config/custom_components/gree/gree_api.py", line 931, in get_sub_devices_list
    result = await get_result_pack(
             ^^^^^^^^^^^^^^^^^^^^^^
    ...<7 lines>...
    )
    ^
  File "/config/custom_components/gree/gree_api.py", line 426, in get_result_pack
    data = await fetch_result(
           ^^^^^^^^^^^^^^^^^^^
    ...<7 lines>...
    )
    ^
  File "/config/custom_components/gree/gree_api.py", line 382, in fetch_result
    data = get_gree_response_data(received_json, cipher, encryption_version)
  File "/config/custom_components/gree/gree_api.py", line 401, in get_gree_response_data
    pack = decryptedPack.decode("utf-8")
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xbb in position 3: invalid start byte

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/config/custom_components/gree/gree_api.py", line 869, in discover_gree_devices
    discovered_sub_devices = await get_sub_devices_list(
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<5 lines>...
    )
    ^
  File "/config/custom_components/gree/gree_api.py", line 944, in get_sub_devices_list
    raise ValueError(f"Error fetching sub-device list for '{mac_addr}'") from err
ValueError: Error fetching sub-device list for '580d0d30225f'

meirlo avatar Oct 03 '25 12:10 meirlo

@meirlo Thanks for the heads-up. Interestingly, I believe that bit is the same as the current version. I've added a debug log before the faulty line to check the pack content. If you can, rerun again and provide the log output.

p-monteiro avatar Oct 03 '25 17:10 p-monteiro

here is the same operation with the pack dump:

2025-10-04 22:34:32.911 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-04 22:34:32.929 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'\x05wv\xbb\x04\x01\xeaur\xfa\xd1\xc8\xdew\x99\x82\\\x85#*\xef\xcc\x95\xdf^\xa4\xc5Ne\xeae\xaeI\x8e\xbfna\x13\xff\xbe|R\xac=\xf2{z\x97\x95\x95\xb3\xf5\xd1\xbe\xbe\xf0tn\x96\x1c\xca\xcf\xa5\x97\xc3\x18)\xdb\x0e3I\xbb,\xab\xcc\xdd\xe5\xa2o\xe6v#\x9f\x9b,\xb8\x10\x06\xd2\tk\xa3\xee5D4\xb1\xc9\xcf\x82L\xd44\xf3\xd8\xb6L\xc0\xdaB\xd4!\xeeB\x19\x1c\xbf\xc1\x1f\n>\xbf\x01\xd8\xc6\x9a\xde\xa6,\xfa\x81\xd0\xa1\x1a\xc0\x97\xbd\xa4\x9c/\xad\x88\xa9\xbaA\n\x17l\xa0\xd7\xdd\xc6"Z#\xdcY\x97=A'
2025-10-04 22:34:32.929 ERROR (MainThread) [custom_components.gree.gree_api] Failed to fetch sub-devices
Traceback (most recent call last):
  File "/config/custom_components/gree/gree_api.py", line 932, in get_sub_devices_list
    result = await get_result_pack(
             ^^^^^^^^^^^^^^^^^^^^^^
    ...<7 lines>...
    )
    ^
  File "/config/custom_components/gree/gree_api.py", line 427, in get_result_pack
    data = await fetch_result(
           ^^^^^^^^^^^^^^^^^^^
    ...<7 lines>...
    )
    ^
  File "/config/custom_components/gree/gree_api.py", line 382, in fetch_result
    data = get_gree_response_data(received_json, cipher, encryption_version)
  File "/config/custom_components/gree/gree_api.py", line 402, in get_gree_response_data
    pack = decryptedPack.decode("utf-8")
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xbb in position 3: invalid start byte
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/config/custom_components/gree/gree_api.py", line 870, in discover_gree_devices
    discovered_sub_devices = await get_sub_devices_list(
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<5 lines>...
    )
    ^
  File "/config/custom_components/gree/gree_api.py", line 945, in get_sub_devices_list
    raise ValueError(f"Error fetching sub-device list for '{mac_addr}'") from err
ValueError: Error fetching sub-device list for '580d0d30225f'

meirlo avatar Oct 04 '25 19:10 meirlo

@meirlo Seems like it is obtaining a device key, and that key is not decrypting the pack correctly. I'll have to check in more detail. If you can debug further since I don't have a VRF, it'll be helpful.

p-monteiro avatar Oct 06 '25 08:10 p-monteiro

@RobHofmann @meirlo @domialex I'd like your input on some decisions that are blocking this.

  1. Since this is a big rewrite, I wonder if we should use it to bump the major version (4?) and possibly change the domain to not replace the official integration (as I saw in the bug reports that it might impose some problems). What do you think? This is blocking the config migration feature, as if we change the domain, there's no need to migrate. Users will need to re-add the devices.

  2. I was adding the temperature step back, but I'm not sure of its utility. Is there any device that accepts non-integer ºC/ºF? What's the practical use case here?

p-monteiro avatar Oct 06 '25 08:10 p-monteiro

@meirlo Seems like it is obtaining a device key, and that key is not decrypting the pack correctly. I'll have to check in more detail. If you can debug further since I don't have a VRF, it'll be helpful.

the encryption key should the same for all the sub unit as it calculated only with the mac address (without the sub_mac_addr). I'll try to find some time debug it further

update: I think the get_sub_list command builds to command incorrectly, in the master branch, the json to send is

        jsonPayloadToSend = (
            f'{{"cid": "app","i": 1,"pack": "{pack}","t":"**subList**","tcid":"{str(mac_addr)}","uid": 0}}'
        )

 where in this PR it resolves to `"t":"bind"`

I'm not sure if that's the only issue. as I don't have much time to test that currently.

meirlo avatar Oct 06 '25 10:10 meirlo

@p-monteiro Don't wait for my input, I'm a bit out of free time for GitHub at the moment. Follow your instinct, it's easier to refactor with a major. Bump to 4, change the domain, remove the step. All of this can be adjusted eventually.

domialex avatar Oct 06 '25 11:10 domialex

@meirlo Good catch, I also noticed the subList request uses the default key and not the specific device key, so I also changed to that. Now I'm not sure if this works because the device key is actually the generic one, or the sublist requires the generic one. I've updated the code. Please try whenever you can.

p-monteiro avatar Oct 07 '25 18:10 p-monteiro

I pushed the domain change, beware!

p-monteiro avatar Oct 07 '25 21:10 p-monteiro

@RobHofmann @meirlo @domialex I'd like your input on some decisions that are blocking this.

  1. Since this is a big rewrite, I wonder if we should use it to bump the major version (4?) and possibly change the domain to not replace the official integration (as I saw in the bug reports that it might impose some problems). What do you think? This is blocking the config migration feature, as if we change the domain, there's no need to migrate. Users will need to re-add the devices.
  2. I was adding the temperature step back, but I'm not sure of its utility. Is there any device that accepts non-integer ºC/ºF? What's the practical use case here?
  1. I think its good to take this into account if we are doing a big rewrite anyway, but you've already done it; so good.
  2. My device is able to step in 0,5 degrees (celcius).

RobHofmann avatar Oct 07 '25 22:10 RobHofmann 

2. My device is able to step in 0,5 degrees (celcius).

@RobHofmann Ah ok, I'll add it back. Would a bool for "Supports half increments" be better?

p-monteiro avatar Oct 07 '25 22:10 p-monteiro 

2. My device is able to step in 0,5 degrees (celcius).

@RobHofmann Ah ok, I'll add it back. Would a bool for "Supports half increments" be better?

I would leave the steps option. people can then choose how to do this (even 0.1's are theoretically possible).

RobHofmann avatar Oct 08 '25 07:10 RobHofmann

@RobHofmann I re-added the temperature step, but I limited it to 0.5 increments as the API only supports half ºC and integer ºF. A warning is logged if a non-integer ºF is set, since it is rounded to the nearest integer.

p-monteiro avatar Oct 08 '25 18:10 p-monteiro

@meirlo Good catch, I also noticed the subList request uses the default key and not the specific device key, so I also changed to that. Now I'm not sure if this works because the device key is actually the generic one, or the sublist requires the generic one. I've updated the code. Please try whenever you can.

Sorry it took me a while, quite busy lately. the subList now works, but I'm getting an error message when selecting the device: image

here is the log:

2025-10-08 23:09:08.334 DEBUG (MainThread) [custom_components.gree.config_flow] Found broadcast addresses from HA: ['255.255.255.255']
2025-10-08 23:09:08.334 DEBUG (MainThread) [custom_components.gree.gree_api] Sending broadcast to 255.255.255.255
2025-10-08 23:09:08.334 DEBUG (MainThread) [custom_components.gree.gree_api] Sending broadcast to 192.168.255.255
2025-10-08 23:09:08.334 DEBUG (MainThread) [custom_components.gree.gree_api] Sending broadcast to 10.255.255.255
2025-10-08 23:09:08.335 DEBUG (MainThread) [custom_components.gree.gree_api] Sending broadcast to 172.31.255.255
2025-10-08 23:09:08.335 DEBUG (MainThread) [custom_components.gree.gree_api] Sent broadcast packets, waiting for replies... 
2025-10-08 23:09:13.404 DEBUG (MainThread) [custom_components.gree.gree_api] Got 2 responses in 5 seconds: {'192.168.69.11': '{"t":"pack","i":1,"uid":0,"cid":"","tcid":"","pack":"LP24Ek0OaYogxs3iQLjL4GxVgUZU3rtYupe1YWCCZzmMa9lM2RqI/KytvJ32IsGSZXrOr+MakVzzXHbghPeyiui/giRwi/22P1NeJSbhyoDt21IYC5nmTB0FSNCtGSQCCP/IZpjNt09zcc1aLtS4znlSqBQy8N/2MMZVqZoAQkkJPRFZzjLrUDkhvMjz32yVMkOVsFsTAafzePY7qSehbZIhsbG6Ck8X1+GBAEqEtdxSARmdHzsfl0hV7CQKMyULqf7+wHqDf2mz9uzNFv2ejQPpn0gG1yCMDrcqGdH2dZ87NZwcceL02wWBXsdkOjw4Ulrqi8VIr2r3Cmrm4wCp4K/UPK7Wvj+xDUBarOvvfc+86x4l/dRoudCtrydSECrA"}', '192.168.69.10': '{"t":"pack","cid":"580d0d30225f","tcid":"app","uid":0,"i":1,"pack":"bkVMP61MVBCj+bKj6Nc/0xEr+tLgPK36TXqIj6rcC74JTQTQIGpNxI8D1U8tSJB1pEr7RuJkLnXf1f/7trvXW5M3btthpc8M0pRZm6+g5N2LTf/WV/dAWpRvIRJkq16rT+A+pJrQeGdAWwN6kxXhvK/YNUtrUMnpV863TeyoLi2o90+ZgYyLoH1N26RgWIimQIoYkO/+w8rSr1nvVeJEc9vgCMb5UKzgzUy/KfaBXZXZgQaJ54sp4j+tIDgPXwVO"}\n'}
2025-10-08 23:09:13.404 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"dev","cid":"c03937873cb5","bc":"00000000000000000000000000000000","brand":"gree","catalog":"gree","mac":"c03937873cb5","mid":"10001","model":"gree","name":"","lock":0,"series":"gree","vender":"1","ver":"V2.0.0","ModelType":"21200896","hid":"362001065279+U-WB05RT13V1.23.bin"}\x07\x07\x07\x07\x07\x07\x07'
2025-10-08 23:09:13.405 DEBUG (MainThread) [custom_components.gree.gree_api] Discovered device: GreeDiscoveredDevice(name='Gree 3cb5', host='192.168.69.11', mac='c03937873cb5', port=7000, brand='gree', model='gree', uid=0)
2025-10-08 23:09:13.405 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"dev","bc":"","catalog":"gree","series":"gree","model":"gree","lock":0,"vender":"1","mid":"60","name":"GR-Gcloud_60_0a_225f_EC","ver":"V3.2.M","mac":"580d0d30225f","subCnt":4}\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c'
2025-10-08 23:09:13.405 DEBUG (MainThread) [custom_components.gree.gree_api] Trying to fetching sub-devices for '580d0d30225f' (subCount=4)
2025-10-08 23:09:13.405 INFO (MainThread) [custom_components.gree.gree_api] Trying to retrieve device encryption key v1
2025-10-08 23:09:13.405 DEBUG (MainThread) [custom_components.gree.gree_api] Bind Pack: {"mac": "580d0d30225f", "t": "bind", "uid": 0}
2025-10-08 23:09:13.405 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-08 23:09:13.453 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"bindOk","r":200,"mac":"580d0d30225f","key":"3de498fe6382a411"}\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c'
2025-10-08 23:09:13.453 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 1, 'pack': {'t': 'bindOk', 'r': 200, 'mac': '580d0d30225f', 'key': '3de498fe6382a411'}}
2025-10-08 23:09:13.453 INFO (MainThread) [custom_components.gree.gree_api] Fetched device encryption key with version 1 with success
2025-10-08 23:09:13.453 DEBUG (MainThread) [custom_components.gree.gree_api] Fetched encryption key: 3de498fe6382a411
2025-10-08 23:09:13.454 DEBUG (MainThread) [custom_components.gree.gree_api] Sub Bind Pack: {"mac": "580d0d30225f", "i": 1}
2025-10-08 23:09:13.456 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-08 23:09:13.477 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"subList","i":1,"c":4,"r":200,"list":[{"mac":"293b824d550000","mid":"608f"},{"mac":"69630f1e000000","mid":"605c"},{"mac":"57be8c4dce0000","mid":"608f"}]}\x02\x02'
2025-10-08 23:09:13.478 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 1, 'pack': {'t': 'subList', 'i': 1, 'c': 4, 'r': 200, 'list': [{'mac': '293b824d550000', 'mid': '608f'}, {'mac': '69630f1e000000', 'mid': '605c'}, {'mac': '57be8c4dce0000', 'mid': '608f'}]}}
2025-10-08 23:09:13.478 DEBUG (MainThread) [custom_components.gree.gree_api] Discovered sub-device: GreeDiscoveredDevice(name='GR-Gcloud_60_0a_225f_EC', host='192.168.69.10', mac='580d0d30225f', port=7000, brand='gree', model='gree', uid=0)
2025-10-08 23:09:13.478 DEBUG (MainThread) [custom_components.gree.gree_api] Discovered sub-device: GreeDiscoveredDevice(name='GR-Gcloud_60_0a_225f_EC', host='192.168.69.10', mac='580d0d30225f', port=7000, brand='gree', model='gree', uid=0)
2025-10-08 23:09:13.478 DEBUG (MainThread) [custom_components.gree.gree_api] Discovered sub-device: GreeDiscoveredDevice(name='GR-Gcloud_60_0a_225f_EC', host='192.168.69.10', mac='580d0d30225f', port=7000, brand='gree', model='gree', uid=0)
2025-10-08 23:09:19.483 INFO (MainThread) [custom_components.gree.gree_device] Initialize the GREE Device API for: 293b824d550000@580d0d30225f (192.168.69.10:7000)
2025-10-08 23:09:19.483 DEBUG (MainThread) [custom_components.gree.gree_device] Version: None, Key: 
2025-10-08 23:09:19.483 DEBUG (MainThread) [custom_components.gree.gree_device] Trying to get device status
2025-10-08 23:09:19.483 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-08 23:09:19.492 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"dev","bc":"","catalog":"gree","series":"gree","model":"gree","lock":0,"vender":"1","mid":"60","name":"GR-Gcloud_60_0a_225f_EC","ver":"V3.2.M","mac":"580d0d30225f","subCnt":4}\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c'
2025-10-08 23:09:19.492 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 1, 'pack': {'t': 'dev', 'bc': '', 'catalog': 'gree', 'series': 'gree', 'model': 'gree', 'lock': 0, 'vender': '1', 'mid': '60', 'name': 'GR-Gcloud_60_0a_225f_EC', 'ver': 'V3.2.M', 'mac': '580d0d30225f', 'subCnt': 4}}
2025-10-08 23:09:19.492 DEBUG (MainThread) [custom_components.gree.gree_api] {'t': 'dev', 'bc': '', 'catalog': 'gree', 'series': 'gree', 'model': 'gree', 'lock': 0, 'vender': '1', 'mid': '60', 'name': 'GR-Gcloud_60_0a_225f_EC', 'ver': 'V3.2.M', 'mac': '580d0d30225f', 'subCnt': 4}
2025-10-08 23:09:19.493 INFO (MainThread) [custom_components.gree.gree_device] No encryption key provided
2025-10-08 23:09:19.493 INFO (MainThread) [custom_components.gree.gree_api] Trying to retrieve device encryption key v1
2025-10-08 23:09:19.493 DEBUG (MainThread) [custom_components.gree.gree_api] Bind Pack: {"mac": "580d0d30225f", "t": "bind", "uid": 0}
2025-10-08 23:09:19.493 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-08 23:09:19.504 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"bindOk","r":200,"mac":"580d0d30225f","key":"3de498fe6382a411"}\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c'
2025-10-08 23:09:19.505 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 1, 'pack': {'t': 'bindOk', 'r': 200, 'mac': '580d0d30225f', 'key': '3de498fe6382a411'}}
2025-10-08 23:09:19.505 INFO (MainThread) [custom_components.gree.gree_api] Fetched device encryption key with version 1 with success
2025-10-08 23:09:19.505 DEBUG (MainThread) [custom_components.gree.gree_api] Fetched encryption key: 3de498fe6382a411
2025-10-08 23:09:19.505 DEBUG (MainThread) [custom_components.gree.gree_api] Trying to get device status
2025-10-08 23:09:19.505 DEBUG (MainThread) [custom_components.gree.gree_api] Status Pack: {"cols": ["Pow", "Mod", "WdSpd", "SetTem", "TemRec", "TemUn", "SwingLfRig", "SwUpDn", "Quiet", "Tur", "Air", "Blo", "Health", "SwhSlp", "SlpMod", "Lig", "StHt", "SvSt", "AntiDirectBlow", "LigSen", "TemSen", "OutEnvTem", "DwatSen", "HeatCoolType"], "mac": "293b824d550000", "t": "status"}
2025-10-08 23:09:19.505 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-08 23:09:19.534 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"dat","mac":"293b824d550000","cols":["Pow","Mod","WdSpd","SetTem","TemRec","TemUn","SwingLfRig","SwUpDn","Quiet","Tur","Air","Blo","Health","SwhSlp","SlpMod","Lig","StHt","SvSt","AntiDirectBlow","LigSen","TemSen","OutEnvTem","DwatSen","HeatCoolType"],"dat":[0,1,0,24,"","",0,0,0,0,0,0,"",0,"","","",0,"","","","","",""],"r":200}\x03\x03\x03'
2025-10-08 23:09:19.534 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 0, 'pack': {'t': 'dat', 'mac': '293b824d550000', 'cols': ['Pow', 'Mod', 'WdSpd', 'SetTem', 'TemRec', 'TemUn', 'SwingLfRig', 'SwUpDn', 'Quiet', 'Tur', 'Air', 'Blo', 'Health', 'SwhSlp', 'SlpMod', 'Lig', 'StHt', 'SvSt', 'AntiDirectBlow', 'LigSen', 'TemSen', 'OutEnvTem', 'DwatSen', 'HeatCoolType'], 'dat': [0, 1, 0, 24, '', '', 0, 0, 0, 0, 0, 0, '', 0, '', '', '', 0, '', '', '', '', '', ''], 'r': 200}}
2025-10-08 23:09:21.064 INFO (MainThread) [custom_components.gree.gree_device] Initialize the GREE Device API for: 293b824d550000@580d0d30225f (192.168.69.10:7000)
2025-10-08 23:09:21.064 DEBUG (MainThread) [custom_components.gree.gree_device] Version: None, Key: 
2025-10-08 23:09:21.064 DEBUG (MainThread) [custom_components.gree.gree_device] Trying to get device status
2025-10-08 23:09:21.064 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-08 23:09:21.080 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"dev","bc":"","catalog":"gree","series":"gree","model":"gree","lock":0,"vender":"1","mid":"60","name":"GR-Gcloud_60_0a_225f_EC","ver":"V3.2.M","mac":"580d0d30225f","subCnt":4}\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c'
2025-10-08 23:09:21.080 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 1, 'pack': {'t': 'dev', 'bc': '', 'catalog': 'gree', 'series': 'gree', 'model': 'gree', 'lock': 0, 'vender': '1', 'mid': '60', 'name': 'GR-Gcloud_60_0a_225f_EC', 'ver': 'V3.2.M', 'mac': '580d0d30225f', 'subCnt': 4}}
2025-10-08 23:09:21.080 DEBUG (MainThread) [custom_components.gree.gree_api] {'t': 'dev', 'bc': '', 'catalog': 'gree', 'series': 'gree', 'model': 'gree', 'lock': 0, 'vender': '1', 'mid': '60', 'name': 'GR-Gcloud_60_0a_225f_EC', 'ver': 'V3.2.M', 'mac': '580d0d30225f', 'subCnt': 4}
2025-10-08 23:09:21.080 INFO (MainThread) [custom_components.gree.gree_device] No encryption key provided
2025-10-08 23:09:21.080 INFO (MainThread) [custom_components.gree.gree_api] Trying to retrieve device encryption key v1
2025-10-08 23:09:21.080 DEBUG (MainThread) [custom_components.gree.gree_api] Bind Pack: {"mac": "580d0d30225f", "t": "bind", "uid": 0}
2025-10-08 23:09:21.081 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-08 23:09:21.094 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"bindOk","r":200,"mac":"580d0d30225f","key":"3de498fe6382a411"}\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c'
2025-10-08 23:09:21.094 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 1, 'pack': {'t': 'bindOk', 'r': 200, 'mac': '580d0d30225f', 'key': '3de498fe6382a411'}}
2025-10-08 23:09:21.094 INFO (MainThread) [custom_components.gree.gree_api] Fetched device encryption key with version 1 with success
2025-10-08 23:09:21.094 DEBUG (MainThread) [custom_components.gree.gree_api] Fetched encryption key: 3de498fe6382a411
2025-10-08 23:09:21.095 DEBUG (MainThread) [custom_components.gree.gree_api] Trying to get device status
2025-10-08 23:09:21.095 DEBUG (MainThread) [custom_components.gree.gree_api] Status Pack: {"cols": ["Pow", "Mod", "WdSpd", "SetTem", "TemRec", "TemUn", "SwingLfRig", "SwUpDn", "Quiet", "Tur", "Air", "Blo", "Health", "SwhSlp", "SlpMod", "Lig", "StHt", "SvSt", "AntiDirectBlow", "LigSen", "TemSen", "OutEnvTem", "DwatSen", "HeatCoolType"], "mac": "293b824d550000", "t": "status"}
2025-10-08 23:09:21.095 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-08 23:09:21.122 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"dat","mac":"293b824d550000","cols":["Pow","Mod","WdSpd","SetTem","TemRec","TemUn","SwingLfRig","SwUpDn","Quiet","Tur","Air","Blo","Health","SwhSlp","SlpMod","Lig","StHt","SvSt","AntiDirectBlow","LigSen","TemSen","OutEnvTem","DwatSen","HeatCoolType"],"dat":[0,1,0,24,"","",0,0,0,0,0,0,"",0,"","","",0,"","","","","",""],"r":200}\x03\x03\x03'
2025-10-08 23:09:21.122 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 0, 'pack': {'t': 'dat', 'mac': '293b824d550000', 'cols': ['Pow', 'Mod', 'WdSpd', 'SetTem', 'TemRec', 'TemUn', 'SwingLfRig', 'SwUpDn', 'Quiet', 'Tur', 'Air', 'Blo', 'Health', 'SwhSlp', 'SlpMod', 'Lig', 'StHt', 'SvSt', 'AntiDirectBlow', 'LigSen', 'TemSen', 'OutEnvTem', 'DwatSen', 'HeatCoolType'], 'dat': [0, 1, 0, 24, '', '', 0, 0, 0, 0, 0, 0, '', 0, '', '', '', 0, '', '', '', '', '', ''], 'r': 200}}

Please let me know if you have an idea where the issue is, or need me to debug further. Thanks for investing time on that, really appreciate your's (and everyone else) efforts to support VRF

meirlo avatar Oct 08 '25 20:10 meirlo

@meirlo Thanks for your patience with us. I've improved the debug and some typos to actually surface the error in the logs. I suspect now you will be able to add the device, but will have errors while using it. Either way, please post the logs whenever you can.

p-monteiro avatar Oct 08 '25 21:10 p-monteiro

here is the next error :) image

2025-10-09 10:49:07.378 DEBUG (MainThread) [custom_components.gree] Setting up entry: <ConfigEntry entry_id=01K73Z08C98C2VCNE7CG496V3X version=2 domain=gree_custom title=GR-Gcloud_60_0a_225f_EC@293b state=ConfigEntryState.SETUP_IN_PROGRESS unique_id=293b824d550000>
{'name': 'GR-Gcloud_60_0a_225f_EC@293b', 'host': '192.168.69.10', 'mac': '293b824d550000@580d0d30225f', 'advanced': {'port': 7000, 'encryption_version': <EncryptionVersion.V1: 1>, 'encryption_key': '3de498fe6382a411', 'uid': 0, 'disable_available_check': False, 'max_online_attempts': 5, 'timeout': 10}, 'hvac_modes': ['auto', 'cool', 'dry', 'fan_only', 'heat', 'off'], 'fan_modes': ['Auto', 'Low', 'MediumLow', 'Medium', 'MediumHigh', 'High', 'turbo', 'quiet'], 'swing_modes': ['Default', 'FullSwing', 'FixedUpper', 'FixedUpperMiddle', 'FixedMiddle', 'FixedLowerMiddle', 'FixedLower', 'SwingLower', 'SwingLowerMiddle', 'SwingMiddle', 'SwingUpperMiddle', 'SwingUpper'], 'swing_horizontal_modes': ['Default', 'FullSwing', 'Left', 'LeftCenter', 'Center', 'RightCenter', 'Right'], 'features': ['beeper', 'air', 'xfan', 'sleep', 'eightdegheat', 'lights', 'health', 'anti_direct_blow', 'powersave', 'light_sensor'], 'target_temp_step': 1.0, 'external_temperature_sensor': 'None', 'external_humidity_sensor': 'None', 'restore_states': True}
2025-10-09 10:49:07.378 INFO (MainThread) [custom_components.gree.gree_device] Initialize the GREE Device API for: 293b824d550000@580d0d30225f (192.168.69.10:7000)
2025-10-09 10:49:07.378 DEBUG (MainThread) [custom_components.gree.gree_device] Version: 1, Key: 3de49
2025-10-09 10:49:07.378 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-09 10:49:07.391 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"dev","bc":"","catalog":"gree","series":"gree","model":"gree","lock":0,"vender":"1","mid":"60","name":"GR-Gcloud_60_0a_225f_EC","ver":"V3.2.M","mac":"580d0d30225f","subCnt":4}\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c'
2025-10-09 10:49:07.391 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 1, 'pack': {'t': 'dev', 'bc': '', 'catalog': 'gree', 'series': 'gree', 'model': 'gree', 'lock': 0, 'vender': '1', 'mid': '60', 'name': 'GR-Gcloud_60_0a_225f_EC', 'ver': 'V3.2.M', 'mac': '580d0d30225f', 'subCnt': 4}}
2025-10-09 10:49:07.391 DEBUG (MainThread) [custom_components.gree.gree_api] {'t': 'dev', 'bc': '', 'catalog': 'gree', 'series': 'gree', 'model': 'gree', 'lock': 0, 'vender': '1', 'mid': '60', 'name': 'GR-Gcloud_60_0a_225f_EC', 'ver': 'V3.2.M', 'mac': '580d0d30225f', 'subCnt': 4}
2025-10-09 10:49:07.391 INFO (MainThread) [custom_components.gree.gree_device] Using the provided encryption key with version 1
2025-10-09 10:49:07.391 DEBUG (MainThread) [custom_components.gree] Bound to device 192.168.69.10
2025-10-09 10:49:07.392 DEBUG (MainThread) [custom_components.gree.gree_device] Trying to get device status
2025-10-09 10:49:07.392 DEBUG (MainThread) [custom_components.gree.gree_api] Trying to get device status
2025-10-09 10:49:07.392 DEBUG (MainThread) [custom_components.gree.gree_api] Status Pack: {"cols": ["Pow", "Mod", "WdSpd", "SetTem", "TemRec", "TemUn", "SwingLfRig", "SwUpDn", "Quiet", "Tur", "Air", "Blo", "Health", "SwhSlp", "SlpMod", "Lig", "StHt", "SvSt", "AntiDirectBlow", "LigSen", "TemSen", "OutEnvTem", "DwatSen", "HeatCoolType"], "mac": "293b824d550000", "t": "status"}
2025-10-09 10:49:07.392 DEBUG (MainThread) [custom_components.gree.gree_api] Payload: {'cid': 'app', 'i': 0, 'pack': 'rZ8nuCEJpoBu9vx086El1RSlbVikgZfPvjPf25P1+DHJPwAdkGW83HJT5abT6TQegRcAvA+oPIL9kXRTSYzjpb6nQJhHxz+YnRx94uW0AMu08lLB3tsGKBLEmuXb5+227wRXS/txAIUehIfUyxBACriWqq+oEYiIcFjj/JyuNhTet4NWL+fArjVUEDRohEV7R+O6ri6vzyp/b/6tz9M1zd6usC/J/Dv/WO2RPJkoDucFnTnNMd8GFpKi4r/IpjVTREiM+QSzNYplEq+nN/xE3QfEK8F9NuvUmZNuVs8gtHhgeJYpxoevfG1lwclfW5lM+LYlxEgOqV09fJzfRkE1eoXCT/rAP8tT2X1faBzfQv7ay1B/8b6/9TXbJ/tGwkaY', 't': 'pack', 'tcid': '580d0d30225f', 'uid': 0}
2025-10-09 10:49:07.392 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-09 10:49:07.420 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"dat","mac":"293b824d550000","cols":["Pow","Mod","WdSpd","SetTem","TemRec","TemUn","SwingLfRig","SwUpDn","Quiet","Tur","Air","Blo","Health","SwhSlp","SlpMod","Lig","StHt","SvSt","AntiDirectBlow","LigSen","TemSen","OutEnvTem","DwatSen","HeatCoolType"],"dat":[0,1,0,24,"","",0,0,0,0,0,0,"",0,"","","",0,"","","","","",""],"r":200}\x03\x03\x03'
2025-10-09 10:49:07.421 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 0, 'pack': {'t': 'dat', 'mac': '293b824d550000', 'cols': ['Pow', 'Mod', 'WdSpd', 'SetTem', 'TemRec', 'TemUn', 'SwingLfRig', 'SwUpDn', 'Quiet', 'Tur', 'Air', 'Blo', 'Health', 'SwhSlp', 'SlpMod', 'Lig', 'StHt', 'SvSt', 'AntiDirectBlow', 'LigSen', 'TemSen', 'OutEnvTem', 'DwatSen', 'HeatCoolType'], 'dat': [0, 1, 0, 24, '', '', 0, 0, 0, 0, 0, 0, '', 0, '', '', '', 0, '', '', '', '', '', ''], 'r': 200}}
2025-10-09 10:49:07.421 DEBUG (MainThread) [custom_components.gree.coordinator] Finished fetching Gree Coordinator 293b824d550000 data in 0.029 seconds (success: False)
2025-10-09 10:49:27.723 DEBUG (MainThread) [custom_components.gree] Setting up entry: <ConfigEntry entry_id=01K73Z08C98C2VCNE7CG496V3X version=2 domain=gree_custom title=GR-Gcloud_60_0a_225f_EC@293b state=ConfigEntryState.SETUP_IN_PROGRESS unique_id=293b824d550000>
{'name': 'GR-Gcloud_60_0a_225f_EC@293b', 'host': '192.168.69.10', 'mac': '293b824d550000@580d0d30225f', 'advanced': {'port': 7000, 'encryption_version': <EncryptionVersion.V1: 1>, 'encryption_key': '3de498fe6382a411', 'uid': 0, 'disable_available_check': False, 'max_online_attempts': 5, 'timeout': 10}, 'hvac_modes': ['auto', 'cool', 'dry', 'fan_only', 'heat', 'off'], 'fan_modes': ['Auto', 'Low', 'MediumLow', 'Medium', 'MediumHigh', 'High', 'turbo', 'quiet'], 'swing_modes': ['Default', 'FullSwing', 'FixedUpper', 'FixedUpperMiddle', 'FixedMiddle', 'FixedLowerMiddle', 'FixedLower', 'SwingLower', 'SwingLowerMiddle', 'SwingMiddle', 'SwingUpperMiddle', 'SwingUpper'], 'swing_horizontal_modes': ['Default', 'FullSwing', 'Left', 'LeftCenter', 'Center', 'RightCenter', 'Right'], 'features': ['beeper', 'air', 'xfan', 'sleep', 'eightdegheat', 'lights', 'health', 'anti_direct_blow', 'powersave', 'light_sensor'], 'target_temp_step': 1.0, 'external_temperature_sensor': 'None', 'external_humidity_sensor': 'None', 'restore_states': True}
2025-10-09 10:49:27.723 INFO (MainThread) [custom_components.gree.gree_device] Initialize the GREE Device API for: 293b824d550000@580d0d30225f (192.168.69.10:7000)
2025-10-09 10:49:27.723 DEBUG (MainThread) [custom_components.gree.gree_device] Version: 1, Key: 3de49
2025-10-09 10:49:27.723 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-09 10:49:27.741 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"dev","bc":"","catalog":"gree","series":"gree","model":"gree","lock":0,"vender":"1","mid":"60","name":"GR-Gcloud_60_0a_225f_EC","ver":"V3.2.M","mac":"580d0d30225f","subCnt":4}\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c\x0c'
2025-10-09 10:49:27.741 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 1, 'pack': {'t': 'dev', 'bc': '', 'catalog': 'gree', 'series': 'gree', 'model': 'gree', 'lock': 0, 'vender': '1', 'mid': '60', 'name': 'GR-Gcloud_60_0a_225f_EC', 'ver': 'V3.2.M', 'mac': '580d0d30225f', 'subCnt': 4}}
2025-10-09 10:49:27.741 DEBUG (MainThread) [custom_components.gree.gree_api] {'t': 'dev', 'bc': '', 'catalog': 'gree', 'series': 'gree', 'model': 'gree', 'lock': 0, 'vender': '1', 'mid': '60', 'name': 'GR-Gcloud_60_0a_225f_EC', 'ver': 'V3.2.M', 'mac': '580d0d30225f', 'subCnt': 4}
2025-10-09 10:49:27.741 INFO (MainThread) [custom_components.gree.gree_device] Using the provided encryption key with version 1
2025-10-09 10:49:27.741 DEBUG (MainThread) [custom_components.gree] Bound to device 192.168.69.10
2025-10-09 10:49:27.741 DEBUG (MainThread) [custom_components.gree.gree_device] Trying to get device status
2025-10-09 10:49:27.741 DEBUG (MainThread) [custom_components.gree.gree_api] Trying to get device status
2025-10-09 10:49:27.741 DEBUG (MainThread) [custom_components.gree.gree_api] Status Pack: {"cols": ["Pow", "Mod", "WdSpd", "SetTem", "TemRec", "TemUn", "SwingLfRig", "SwUpDn", "Quiet", "Tur", "Air", "Blo", "Health", "SwhSlp", "SlpMod", "Lig", "StHt", "SvSt", "AntiDirectBlow", "LigSen", "TemSen", "OutEnvTem", "DwatSen", "HeatCoolType"], "mac": "293b824d550000", "t": "status"}
2025-10-09 10:49:27.742 DEBUG (MainThread) [custom_components.gree.gree_api] Payload: {'cid': 'app', 'i': 0, 'pack': 'rZ8nuCEJpoBu9vx086El1RSlbVikgZfPvjPf25P1+DHJPwAdkGW83HJT5abT6TQegRcAvA+oPIL9kXRTSYzjpb6nQJhHxz+YnRx94uW0AMu08lLB3tsGKBLEmuXb5+227wRXS/txAIUehIfUyxBACriWqq+oEYiIcFjj/JyuNhTet4NWL+fArjVUEDRohEV7R+O6ri6vzyp/b/6tz9M1zd6usC/J/Dv/WO2RPJkoDucFnTnNMd8GFpKi4r/IpjVTREiM+QSzNYplEq+nN/xE3QfEK8F9NuvUmZNuVs8gtHhgeJYpxoevfG1lwclfW5lM+LYlxEgOqV09fJzfRkE1eoXCT/rAP8tT2X1faBzfQv7ay1B/8b6/9TXbJ/tGwkaY', 't': 'pack', 'tcid': '580d0d30225f', 'uid': 0}
2025-10-09 10:49:27.742 DEBUG (MainThread) [custom_components.gree.gree_api] Fetching data from 192.168.69.10
2025-10-09 10:49:27.784 DEBUG (MainThread) [custom_components.gree.gree_api] Decoding pack: b'{"t":"dat","mac":"293b824d550000","cols":["Pow","Mod","WdSpd","SetTem","TemRec","TemUn","SwingLfRig","SwUpDn","Quiet","Tur","Air","Blo","Health","SwhSlp","SlpMod","Lig","StHt","SvSt","AntiDirectBlow","LigSen","TemSen","OutEnvTem","DwatSen","HeatCoolType"],"dat":[0,1,0,24,"","",0,0,0,0,0,0,"",0,"","","",0,"","","","","",""],"r":200}\x03\x03\x03'
2025-10-09 10:49:27.784 DEBUG (MainThread) [custom_components.gree.gree_api] Got data from 192.168.69.10: {'t': 'pack', 'cid': '580d0d30225f', 'tcid': 'app', 'uid': 0, 'i': 0, 'pack': {'t': 'dat', 'mac': '293b824d550000', 'cols': ['Pow', 'Mod', 'WdSpd', 'SetTem', 'TemRec', 'TemUn', 'SwingLfRig', 'SwUpDn', 'Quiet', 'Tur', 'Air', 'Blo', 'Health', 'SwhSlp', 'SlpMod', 'Lig', 'StHt', 'SvSt', 'AntiDirectBlow', 'LigSen', 'TemSen', 'OutEnvTem', 'DwatSen', 'HeatCoolType'], 'dat': [0, 1, 0, 24, '', '', 0, 0, 0, 0, 0, 0, '', 0, '', '', '', 0, '', '', '', '', '', ''], 'r': 200}}
2025-10-09 10:49:27.784 DEBUG (MainThread) [custom_components.gree.coordinator] Finished fetching Gree Coordinator 293b824d550000 data in 0.043 seconds (success: False)

BTW, I see that this integration does not override the official integration anymore and also the Gree logo is missing.

meirlo avatar Oct 09 '25 07:10 meirlo

BTW, I see that this integration does not override the official integration anymore and also the Gree logo is missing.

@meirlo

That is intended. Once we go through with this PR, we can PR the logo on the official custom integration brands.

About the error, as predicted, the device was added, but now it is failing to get the status, which is weird since the log shows that it receives the status correctly, and there is no exception logged. I'll check later.

Update: Actually, I see that some important fields are blank. Do you happen to know if some of the properties are given by the main device while others are given by the subdevices? That can explain the problem. Also, can you provide screenshots of how the official app organizes the settings for the VRF?

p-monteiro avatar Oct 09 '25 08:10 p-monteiro

Screenshot_20251012_142342_GREE+

The office AC is the only standalone one and is not part of the vrf system.

The living room is the main one, meaning it controls the cool/heat setting for all the vrf ac (since there only a single outdoor unit, it's impossible to set some indoor units to cool and some to heating), it is possible to change this setting for other ac units, but it will revert to Fan mode if that's conflict with the main ac.

Here are some screenshots from the bedroom ac:

Screenshot_20251012_142423_GREE+ Screenshot_20251012_142410_GREE+ Screenshot_20251012_142359_GREE+

Please let me know if you want a screenshot from a specific ac/page

meirlo avatar Oct 12 '25 18:10 meirlo

@meirlo Thanks for the screenshots, I'm having a bit of a hard time understanding the options, not gonna lie.

More importantly, how would you expect the controls to work in Home Assistant in terms of devices and the controls they provide? For example, would you prefer for all controls to be in all devices and when changing it goes to the fan (as you said), or the subdevices override the main device, or the controls not show for the subdevices, or another thing?

p-monteiro avatar Oct 12 '25 18:10 p-monteiro

@p-monteiro does it looks different on your ac? Because the standalone ac and the vrf looks very similar. If some setting is not clear please let me know.

In home assistant, I believe each unit needs to be a separate device, with its own settings. similar to how it shows in the gree+ app.

The limitation of the mode that must be set on the main unit first, can be ignored. It is possible to set a mode that conflicts with the main with the gree app or even the ac.

if one want to sync between the mode in all ac it can be done via automation, no need to over complicate the integration.

meirlo avatar Oct 12 '25 18:10 meirlo

@meirlo The thing is, at first glance, the subdevices API does not provide some of the parameters that you want (they came empty in the status pack, but it needs to be further investigated), so maybe the official app sends commands to both the subunit and the main unit when you change the mode on the subunit. If that's the case, it can actually be easier to make the subunits override the main one, or just omit the properties altogether.

I just pushed a commit, please try it, and check if the main device can be discovered, added and it works. Ignore the subunits for a moment hehe

p-monteiro avatar Oct 12 '25 18:10 p-monteiro

This might need some architectural changes in the way we communicate with the device (possibly to communicate with the main and sub devices for getting and setting the status)

p-monteiro avatar Oct 12 '25 18:10 p-monteiro

@meirlo Another thing, in a VRF system all units are the same as the main one right? So the capabilities of them all are the same.

p-monteiro avatar Oct 12 '25 18:10 p-monteiro

I'm getting an error when trying to add the entity without the sub unit

Logger: custom_components.gree.climate
Source: custom_components/gree/climate.py:846
integration: gree (documentation, issues)
First occurred: 5:37:20 PM (1 occurrence)
Last logged: 5:37:20 PM

Error in 'async_set_temperature'
Traceback (most recent call last):
  File "/config/custom_components/gree/gree_api.py", line 372, in fetch_result
    received_json = await udp_request_async(
                    ^^^^^^^^^^^^^^^^^^^^^^^^
        ip_addr, port, json_data, max_connection_attempts, timeout
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/config/custom_components/gree/gree_api.py", line 302, in udp_request_async
    raise ValueError(
        f"Failed to communicate with device '{ip_addr}:{port}' after {max_retries} attempts"
    )
ValueError: Failed to communicate with device '192.168.69.10:7000' after 5 attempts

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/config/custom_components/gree/gree_api.py", line 719, in gree_set_status
    result = await get_result_pack(
             ^^^^^^^^^^^^^^^^^^^^^^
    ...<7 lines>...
    )
    ^
  File "/config/custom_components/gree/gree_api.py", line 428, in get_result_pack
    data = await fetch_result(
           ^^^^^^^^^^^^^^^^^^^
    ...<7 lines>...
    )
    ^
  File "/config/custom_components/gree/gree_api.py", line 376, in fetch_result
    raise ValueError(f"Error communicating with {ip_addr}: {err}") from err
ValueError: Error communicating with 192.168.69.10: Failed to communicate with device '192.168.69.10:7000' after 5 attempts

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/config/custom_components/gree/gree_device.py", line 248, in update_device_status
    await gree_set_status(
    ...<10 lines>...
    )
  File "/config/custom_components/gree/gree_api.py", line 729, in gree_set_status
    raise ValueError("Error getting device status") from err
ValueError: Error getting device status

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/config/custom_components/gree/climate.py", line 846, in async_set_temperature
    await self.device.update_device_status()
  File "/config/custom_components/gree/gree_device.py", line 265, in update_device_status
    raise ValueError("Error setting device status") from err
ValueError: Error setting device status

For the second question, the indoor units are not always identical. For example, my living room ac is a different one than the rest.

Can you please elaborate which parameters are missing?

meirlo avatar Oct 15 '25 16:10 meirlo

@meirlo I'm having a hard time debugging the issue, sorry. Please try the latest version and provide the full debug log, not only the exception. Your error shows a problem communicating with the device, so either the connection is the problem or the pack sent to the device is invalid, and it does not respond correctly.

p-monteiro avatar Oct 15 '25 18:10 p-monteiro

I've been using this for some time now to control my AC without any problem. It would be nice to have more people trying out the latest commit to find bugs or missing features so this can be merged, including people with VRF.

p-monteiro avatar Nov 25 '25 22:11 p-monteiro