roaring icon indicating copy to clipboard operation
roaring copied to clipboard

BitSliceIndexing BSI sub-library correctly stores twos complement values but range comparisons fail for negative values.

Open guymolinari opened this issue 4 years ago • 2 comments

Negative values are correctly stored and retrieved, however when performing any comparisons LT, GT, GE, LE, RANGE against negative values they fail horribly.

guymolinari avatar Jun 14 '21 20:06 guymolinari

@guymolinari Couldn't we document that we are supporting only non-negative values? That was my expectation.

lemire avatar Jun 14 '21 20:06 lemire

Daniel, I just checked in a fix for this. What do you think?

I'm also going to add min() and max() functions. I need this stuff. Guy

On Mon, Jun 14, 2021 at 1:07 PM Daniel Lemire @.***> wrote:

@guymolinari https://github.com/guymolinari Couldn't we document that we are supporting only non-negative values? That was my expectation.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RoaringBitmap/roaring/issues/315#issuecomment-860958650, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADZZAUXIEFPMHBZXJ454COLTSZOPZANCNFSM46V4GR4A .

guymolinari avatar Jun 14 '21 20:06 guymolinari