developer-relations icon indicating copy to clipboard operation
developer-relations copied to clipboard

[DOCS][BUG] `match-v5.EventsTimeLineDto` missing documentation for many enum variant fields

Open MingweiSamuel opened this issue 1 year ago • 2 comments

here's what I have that is missing from docs, not sure if they're all still used or not. The struct acts like a tagged enum it seems

      "itemId": {
        "type": "integer",
        "format": "int32"
      },
      "participantId": {
        "type": "integer",
        "format": "int32"
      },
      "levelUpType": {
        "type": "string"
      },
      "skillSlot": {
        "type": "integer",
        "format": "int32"
      },
      "creatorId": {
        "type": "integer",
        "format": "int32"
      },
      "wardType": {
        "type": "string"
      },
      "level": {
        "type": "integer",
        "format": "int32"
      },
      "assistingParticipantIds": {
        "type": "array",
        "items": {
          "type": "integer",
          "format": "int32"
        }
      },
      "bounty": {
        "type": "integer",
        "format": "int32"
      },
      "killStreakLength": {
        "type": "integer",
        "format": "int32"
      },
      "killerId": {
        "type": "integer",
        "format": "int32"
      },
      "position": {
        "$ref": "#/components/schemas/match-v5.PositionDto"
      },
      "victimDamageDealt": {
        "type": "array",
        "items": {
          "$ref": "#/components/schemas/match-v5.MatchTimelineVictimDamage" // See below
        }
      },
      "victimDamageReceived": {
        "type": "array",
        "items": {
          "$ref": "#/components/schemas/match-v5.MatchTimelineVictimDamage" // See below
        }
      },
      "victimId": {
        "type": "integer",
        "format": "int32"
      },
      "killType": {
        "type": "string"
      },
      "laneType": {
        "type": "string"
      },
      "teamId": {
        "type": "integer",
        "format": "int32",
        "x-enum": "team"
      },
      "multiKillLength": {
        "type": "integer",
        "format": "int32"
      },
      "killerTeamId": {
        "type": "integer",
        "format": "int32",
        "x-enum": "team"
      },
      "monsterType": {
        "type": "string"
      },
      "monsterSubType": {
        "type": "string"
      },
      "buildingType": {
        "type": "string"
      },
      "towerType": {
        "type": "string"
      },
      "afterId": {
        "type": "integer",
        "format": "int32"
      },
      "beforeId": {
        "type": "integer",
        "format": "int32"
      },
      "goldGain": {
        "type": "integer",
        "format": "int32"
      },
      "gameId": {
        "type": "integer",
        "format": "int64"
      },
      "winningTeam": {
        "type": "integer",
        "format": "int32"
      },
      "transformType": {
        "type": "string"
      },
      "name": {
        "type": "string"
      },

      "shutdownBounty": {
        "type": "integer",
        "format": "int32"
      },
      "actualStartTime": {
        "type": "integer",
        "format": "int64"
      }
"match-v5.MatchTimelineVictimDamage": {
    "title": "MatchTimelineVictimDamage",
    "type": "object",
    "properties": {
      "basic": {
        "type": "boolean"
      },
      "magicDamage": {
        "type": "integer",
        "format": "int32"
      },
      "name": {
        "type": "string"
      },
      "participantId": {
        "type": "integer",
        "format": "int32"
      },
      "physicalDamage": {
        "type": "integer",
        "format": "int32"
      },
      "spellName": {
        "type": "string"
      },
      "spellSlot": {
        "type": "integer",
        "format": "int32"
      },
      "trueDamage": {
        "type": "integer",
        "format": "int32"
      },
      "type": {
        "type": "string"
      }
    },
    "required": [
      "basic",
      "magicDamage",
      "name",
      "participantId",
      "physicalDamage",
      "spellName",
      "spellSlot",
      "trueDamage",
      "type"
    ]
  }

MingweiSamuel avatar May 12 '24 06:05 MingweiSamuel

Hi @MingweiSamuel Do you have some matchIds to validate this one?

f3ar161 avatar Jun 17 '24 16:06 f3ar161

New feats fields: https://github.com/RiotGames/developer-relations/issues/1052

{
  "featType": 0,
  "featValue": 1,
  "teamId": 100,
  "timestamp": 211109,
  "type": "FEAT_UPDATE"
},

MingweiSamuel avatar Feb 25 '25 05:02 MingweiSamuel