developer-relations icon indicating copy to clipboard operation
developer-relations copied to clipboard

[BUG] Item ID 7023 (Equinox) missing requiredAlly field as an Ornn Item

Open tedhli opened this issue 3 years ago • 3 comments

Bug Description
All Ornn items have a field: 'requiredAlly' which maps to 'Ornn' except for item 7023 (Equinox, which upgrades from Evenshroud).

Problem Description
Evenshroud and Equinox were added in patch 11.23, which added many items to the game. While other Mythic items added here have their Ornn counterparts mapped correctly (e.g. Caesura), Equinox does not have the 'requiredAlly': 'Ornn' mapping

Example data Patch 12.17.1 data

Expected Result
I expect all Ornn items to have a field: 'requiredAlly' which maps to 'Ornn', including for item 7023 (Equinox)

Actual Result
This is the current body for item 7023

{
   "name":"Equinox",
   "description":"<mainText><stats><ornnBonus>400</ornnBonus> Health<br><ornnBonus>25</ornnBonus> Ability Haste<br><ornnBonus>40</ornnBonus> Armor<br><ornnBonus>40</ornnBonus> Magic Resist</stats><br><li><passive>Coruscation:</passive> After <status>Immobilizing</status> champions or being <status>Immobilized</status>, cause that target and all nearby enemy Champions to take increased damage.<br><br><rarityMythic>Mythic Passive:</rarityMythic> Grants all other <rarityLegendary>Legendary</rarityLegendary> items <attention> Armor and Magic Resist</attention></mainText><br>",
   "colloq":"",
   "plaintext":"",
   "from":[
      "3001"
   ],
   "inStore":false,
   "image":{
      "full":"7023.png",
      "sprite":"item2.png",
      "group":"item",
      "x":432,
      "y":192,
      "w":48,
      "h":48
   },
   "gold":{
      "base":0,
      "purchasable":false,
      "total":2500,
      "sell":1750
   },
   "tags":[
      "Health",
      "SpellBlock",
      "Armor",
      "AbilityHaste"
   ],
   "maps":{
      "11":true,
      "12":true,
      "21":true,
      "22":false
   },
   "stats":{
      "FlatHPPoolMod":400,
      "FlatSpellBlockMod":40,
      "FlatArmorMod":40
   },
   "depth":4
}

Developer Impact
Impacts how developers are able to automatically generate item recommendations, requiring manual tuning/checkups/poor coding practices to correctly handle malformed data/missing fields.

  • Frequency: Every day when we update our runes.
  • Severity: Causes improperly mapped items
  • Cost: Developer time to manually check for new fields and hardcode values

Player Impact
Makes it more challenging for us to deliver high quality stats and recommendations to players.

tedhli avatar Sep 12 '22 21:09 tedhli

Another issue is that Abyssal Mask is tagged as Consumable but I don't know why that would be the case.

tedhli avatar Sep 12 '22 22:09 tedhli

+1 wrote a small script to find what items were missing the requiredAlly tag:

(async function() {
    const resp = await fetch("https://ddragon.leagueoflegends.com/cdn/13.7.1/data/en_US/item.json");
    const items = await resp.json();
    Object.values(items.data).forEach(itemInfo => {
        if (itemInfo.description.includes('ornnBonus') && itemInfo.requiredAlly !== 'Ornn') {
            console.log(itemInfo);
        }
    });
})()

Missing items: Equinox, Primordial Dawn, Infinite Convergence

stevezease avatar Apr 07 '23 21:04 stevezease

Hi, any update on this ? thanks in advance

RafaelCartenet avatar Jan 24 '24 08:01 RafaelCartenet