developer-relations icon indicating copy to clipboard operation
developer-relations copied to clipboard

[BUG?] old Muramana & Seraph's Embrace in Data Dragon item.json

Open ackerdev opened this issue 5 years ago • 2 comments

Bug Description
http://ddragon.leagueoflegends.com/cdn/11.2.1/data/en_US/item.json These items are duplicated in the list

  • ~Broken Stopwatch (2421, 2424)~
  • ~Kalista's Black Spear (3599, 3600)~
  • Muramana (3042, 3043)
  • Seraph's Embrace (3040, 3048)

The second entries for Muramana (3043) and Seraph's Embrace (3048) looks like they're the pre-mythic data and point to invalid item ids for their "specialRecipe".

Impact Can cause issues with code that traverses the item list and expects the ids in "specialRecipe" to exist. Could cause duplicates to show in end-user interfaces that can't actually be found in-game.

ackerdev avatar Jan 27 '21 03:01 ackerdev

This is not a bug.

Kalista's Spear is twice in there because one is for Sylas.

Broken Stopwatch is probably twice cause theres a difference between a bought and a through runes aquired one.

Muramane and Seraph's I assume have a similar reason to be in there twice.

image

DoctressWasTaken avatar Jan 29 '21 11:01 DoctressWasTaken

OK, Kalista's Spear and Broken Stopwatch aren't bugs.

Muramana and Seraph's Embrace both have specialRecipe's that point to ids that don't exist.

This was originally what I saw and I tried to account for other potential errors; my bad. These ones still appear to be flawed. Updated the ticket to reflect this better.

ackerdev avatar Jan 29 '21 20:01 ackerdev