LoRDeckCodes
LoRDeckCodes copied to clipboard
RiotGames
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.1 to 13.0.1. Release notes Sourced from Newtonsoft.Json's releases. 13.0.1 New feature - Add JsonSelectSettings with configuration for a regex timeout Change - Remove portable assemblies from...
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "dependabot[bot] avatar"){kind=avatar}
This PR has a couple of changes, split out across commits. Happy to drop/split out any commits if felt PR is too big. * Add unit tests for `VarintTranslator` methods...
I wish Riot makes all rules clear so that Expedition decks are supported in all language, especially Python :) Univesal basic format in game: 0001 0010 00000000 00000000 00000000 [copies]+[set]+[region]+[number]...
Here'are two code: CEBAGAICAIUTSBYBAQARWHA7EQ2DUAQCAEBAIOACAECCOKYBAIAQEMJX CEBAGAICAIUTSBYBAQARWHA7EQ2DUAQCAECCOKYCAEBAIOABAIAQEMJX The 2nd code doesn't meet the standard but LoR and all code sites support it. If you import the code in LoR then share it,...
It would be very useful to have the deck name inside the deck code, as after importing the deck we have to select the deck, click edit, and manually type...
https://github.com/RiotGames/LoRDeckCodes/blob/b2211d797da8928669b60384b1caa0e4cadccef7/LoRDeckCodes_Tests/UnitTest1.cs#L270 This tests bad card count under a test for bad card codes, and this specific case is also more aptly tested in another test (`BadCount()`). Suggest changing to test...
The following 2 lines encode the same decks that were already tested by this point, instead of the new decks created, which are never tested (`deck3` and `deck4`). https://github.com/RiotGames/LoRDeckCodes/blob/b2211d797da8928669b60384b1caa0e4cadccef7/LoRDeckCodes_Tests/UnitTest1.cs#L204 https://github.com/RiotGames/LoRDeckCodes/blob/b2211d797da8928669b60384b1caa0e4cadccef7/LoRDeckCodes_Tests/UnitTest1.cs#L205
There are various cards with the card code ending in `T1` `T2` (e.g. 04PZ001T4) etc.. The method `public static string GetCodeFromDeck(List deck)` now fails if you provide it with a...
