feedback icon indicating copy to clipboard operation
feedback copied to clipboard

Exposing allowTaint option of html2canvas to be passed

Open dileepyelleti opened this issue 6 years ago • 6 comments

Currently allowTaint option is hardcoded as true. Because of that it is throwing error in our application having images. Is it possible to expose allowTaint option of html2canvas from our application

dileepyelleti avatar Sep 27 '19 10:09 dileepyelleti

Hi, @dileepyelleti i forked the repo and create a new repository, because the author of this one is no longer active. I have added the allowTaint option and also send event when dialog is canceled https://github.com/digikare/feedback#readme

workfel avatar Jan 28 '20 09:01 workfel

Hi @workfel , I'm using your feedback module, but I guess the dependency for html2canvas is missing in your project. I wasn't able to open an issue, so I'm writing it here.

alinamx avatar Jul 22 '20 13:07 alinamx

Hi @alinamx , What is your version of ngx-md-feedback plz ?

workfel avatar Jul 22 '20 15:07 workfel

Hi,

I'm using version 1.0.9. In the attachment, you can see the version and dependencies.

Thanks, Alina

Johan pujol [email protected] hat am 22.07.2020 17:09 geschrieben:

Hi @alinamx (https://github.com/alinamx) , What is your version of ngx-md-feedback plz ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/RickonChen/feedback/issues/10#issuecomment-662509879), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ABKVF3SQGZ7JFFVI4KEULQ3R436L3ANCNFSM4I3ESLNA).

alinamx avatar Jul 22 '20 19:07 alinamx

Hi @alinamx , You can use the 1.0.10 version, this is solved. Thanks

workfel avatar Jul 23 '20 06:07 workfel

Thank you very much! :)

Johan pujol [email protected] hat am 23.07.2020 08:43 geschrieben:

Hi @alinamx (https://github.com/alinamx) , You can use the 1.0.10 version, this is solved. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/RickonChen/feedback/issues/10#issuecomment-662844331), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ABKVF3RC65ZYXJVMVCWFOW3R47LYLANCNFSM4I3ESLNA).

alinamx avatar Jul 23 '20 06:07 alinamx