define icon indicating copy to clipboard operation
define copied to clipboard

Oxford API version 2 support

Open ghost opened this issue 5 years ago • 2 comments

Tested with go1.14

ghost avatar Mar 25 '20 19:03 ghost

Just tested these changes with go1.11 as well as 1.14 and they run locally. Below are some sources that seem related to the CI checks.


golang/lint Resolving Module Path Problems Non-canonical paths x/build go.mod dependency update

ghost avatar Mar 25 '20 22:03 ghost

I am able to replicate the errored check with make install-deps-dev.

A potential solution is to replace github.com/golang/lint/golint with golang.org/x/lint.

diff --git a/Makefile b/Makefile
index df1bc0f..c445391 100644
--- a/Makefile
+++ b/Makefile
@@ -70,7 +70,7 @@ install-deps:
        go get -d ./...

 install-deps-dev: install-deps
-       go get github.com/golang/lint/golint
+       go get golang.org/x/lint
        go get golang.org/x/tools/cmd/goimports
        go get github.com/mitchellh/gox

@@ -78,7 +78,7 @@ update-deps:
        go get -d -u ./...

 update-deps-dev: update-deps
-       go get -u github.com/golang/lint/golint
+       go get -u golang.org/x/lint
        go get -u golang.org/x/tools/cmd/goimports
        go get -u github.com/mitchellh/gox

This change to the Makefile yields success in go1.14, however make install-deps-dev in go1.11 fails.

Below is the result:

make install-deps-dev
go1.11 get -d ./...
go1.11 get golang.org/x/lint
go: finding golang.org/x/lint latest
go1.11 get golang.org/x/tools/cmd/goimports
go: finding golang.org/x/tools/cmd/goimports latest
go: finding golang.org/x/tools/cmd latest
go: finding golang.org/x/tools latest
go: downloading golang.org/x/tools v0.0.0-20200327195553-82bb89366a1e
go build golang.org/x/mod/semver: module requires Go 1.12
Makefile:76: recipe for target 'install-deps-dev' failed
make: *** [install-deps-dev] Error 1

ghost avatar Mar 27 '20 20:03 ghost