Sync conversation status (Resolved | Unresolved) between ReviewNB & GitHub

Open devikasharma97 opened this issue 2 years ago • 1 comments

Whenever I mark a comment as resolved in ReviewNB it still stays unresolved in Github

Mar 03 '23 15:03 devikasharma97

@devikasharma97 yes, you're right. It's a known limitation at the moment.

Context

For a long time, GitHub didn't offer an API to resolve / unresolve a conversation. Recently, Github launched an API to resolve / unresolve a conversation.

Problem

GitHub requires "write repository" permission to be able to resolve / unresolve a conversation via the API. Currently we don't ask for this permissions as it was not required until now.

Solution

We'll soon be requesting "write repository" permission so we can resolve a conversation on our user's behalf. This permission would also enable us to build some advanced feature like offer & accept suggestions directly from the code review comments UI.

We will keep this issue open for tracking purposes.

Mar 04 '23 05:03 amit1rrr