Escanor Liones
Escanor Liones
The unused variable I think should stay. We should remove variables that are declared and not used. I haven't encountered an scenario where there is a reason not do so.
@CosmoRied @patricklodder @chromatic What is the consensus? What is the work to be done?
@patricklodder I agree with you. > Merging this into 1.14.4 will immediately identify all 1.10.x and 1.14.x based wallets that may have vulnerabilities that we fix in 1.14.4 and any...
This seems to be a non-deterministic problem. On this CI test feelimit.py failed. I ran all the rpc tests several times and I got the following results: 1. Passed all...
@patricklodder Unfortuantely, I did not save the error for the proxy_test.py. I will run it a few more times to see if I can get it again. There are A...
@michilumin Yes!!! That is what I was alluding to when I said: > I actually think there is a simpler way to do this, on newer CPUS anyway, but back...
@patricklodder I will look into this sometime soon. I just squashed the commits on #2482. Sorry it took so long; should've been included in 1.14.5.
@patricklodder @rnicoll Who is working on this? How can I help?
@patricklodder @rnicoll @michilumin This fix requires a significant amount of work to implement properly. See Bitcoins, #11490 ( https://github.com/bitcoin/bitcoin/commit/d93fa261f079d529a94ff26aa406a49e28d10340 ), where the merge description describes the kind of work I...
@patricklodder Given #2459, let's move this one as well to 1.14.5.