RetroPie
locales init
Hi,
i'm from the batocera.linux project. we have migrated to es-retropie for our system, because it is really the best es fork. by doing this, we would like to become retropie-es contributors. i've done a first pr here to include gettext into retropie-es. it is minimal, but the aim is first to validate the process, the rules, and then, i'll add all the strings to translate.
Signed-off-by: Nicolas Adenis-Lamarre [email protected]
2 issues with this PR is the 2 spaces instead of tabs and that this will not compile on windows
- do you have the indentation rules to follow please ? (ideally, the emacs indentation method to use)
- why do you think it will not compile on windows ? ("/usr/share/locale" will not work for sure but not avoid compilation). This is (approximately) the same functions i used on the xmoto game and it compiled it successfully via mingw with cross compilation (from linux for windows). i've no way to compile/work on windows. Should i set #define to avoid gettext on windows ?
@nadenislamarre There is an error because #libintl.h is not found out-of-the-box on Windows (included in localeES.h). It probably needs gettext installed and configured through CMake.
Tried with Visual Studio 2017 (Community).
EDIT: adding the proper includes/libs makes the compilation succeed, so it probably just needs an adjustment to the CMakeLists.txt. For starters, IMHO only Linux should be included and leave Windows under a #define.
- do you have the indentation rules to follow please ? (ideally, the emacs indentation method to use)
In general not. I raised this question a while ago since I felt it is getting more and more important as contributions are gaining momentum (and for several other obvious reasons).
I don't think there's anything set in stone. The default setting, inherited from the original ES code is tabs, each of them 4-spaces wide, I believe.
updated. tabs fixed. compilation fixed in case gettext is not found.