jain-sip icon indicating copy to clipboard operation
jain-sip copied to clipboard

fix NameValueList equals, in case this is an empty NameValueList

Open macvoo opened this issue 8 years ago • 2 comments

Calling NameListValue#equals on a empty NameValueList (handing over another NameValueList) would always return true in the current implementation.

CodeSample: //Given: NameValueList a = new NameValueList(); NameValueList b = new NameValueList(); b.set("someName", "someValue"); //When a.equals(b); --> would be true, but should be false...

macvoo avatar Feb 22 '18 10:02 macvoo

Hey @macvoo !

Thanks for taking the time to submit this PR ❤️ !!

Could you please take a look at our Open Source Playbook and then proceed with signing our CLA, so we can then move forward with processing this?

Thanks in advance! Yorgos

gsaslis avatar Feb 23 '18 00:02 gsaslis

thanks for signing the CLA @macvoo !

Passing this on for review.

gsaslis avatar Mar 06 '18 17:03 gsaslis