Restcomm-Connect icon indicating copy to clipboard operation
Restcomm-Connect copied to clipboard

Error message for closed accounts login in Console

Open otsakir opened this issue 8 years ago • 5 comments

When trying to sign in a closed account, Console displays an "Error. Unknown error" message. Insead, we should display something like: "Sorry, you can't use this account. It has been closed".

otsakir avatar Jan 25 '18 13:01 otsakir

hi @otsakir , I would like to contribute a fix for this ticket. Would you mind if I change the warning message to "Sorry! The account was closed." or can you please specify the warning message you want me to change to.

ddhuy avatar Mar 19 '18 16:03 ddhuy

Hi @ddhuy . Well, i would still go with the first option. i.e. "Sorry, you can't use this account. It has been closed".

Thanks for offering! :+1:

otsakir avatar Mar 21 '18 05:03 otsakir

Hi @otsakir Thank you. I have tried to reproduce the issue you have but seems that the notification message is different (please check the attached images). I checked the code and observed that "Error! Unknown error" is a general error message rather than closed account reason. I roughly guest that it can be another issue you met at that time or am I miss something.

At RC console this is shows that "Error! Login Failed. Please confirm your username and password" rc-console-closed-account-notification

At HTTP response it shows that "Provided account is not active" rc-console-closed-account-response

Is your intend to make difference between wrong authentication & bad permission?

ddhuy avatar Mar 23 '18 07:03 ddhuy

Oops! @ddhuy it looks like the issue is a little outdated. I would say that if the status is different (403 instead of 401 in case of just bad credentials) user deserves a different warning message.

otsakir avatar Mar 23 '18 12:03 otsakir

Hi @otsakir , I have just put a PR#2889 for this issue. Please have a check and let me know your opinion.

ddhuy avatar Mar 28 '18 18:03 ddhuy