RestComm
Issue 2620
@ddhuy can you please sign the Contributor License Agreement at https://telestax.com/open-source/#Contribute so we can accept the contribution ?
@ddhuy the problem with commit https://github.com/RestComm/Restcomm-Connect/pull/2641/commits/b001a77c8ea7f9d1757315dd5affb2e5d52b157c is that you've changed the type of the InvalidEmailException: used to be Exception, now it's RuntimeException.
This means that its usages (e.g. https://github.com/RestComm/Restcomm-Connect/blob/e449462909d5620daa873e9d20818fba6413ac5c/restcomm/restcomm.http/src/main/java/org/restcomm/connect/http/EmailMessagesEndpoint.java#L91 ) after your change now only catch a RuntimeException, instead of the more general Exception.
I am not sure this is a valid / intended change... ?
@gsaslis , Thanks for your reviewing time and comments. I think make the InvalidEmailException sub-class from RuntimeException is more cleaner and easier for usage. But since sub-class from Exception or RuntimeException has not much different, so I will revert it back to keep minimum effect of the change.
@ddhuy just to be clear: there is a difference between Exception and RuntimeException and it's a big one. The former is a checked exception, the latter is unchecked, leading to completely different handling.
Here's some further reading on this topic https://www.ibm.com/developerworks/library/j-jtp05254/index.html , but there's a broad discussion on checked vs. unchecked exceptions and google is your friend. ; )
I am passing your PR on for review from the core team.
Hi all, I have tried to resolve the merging conflict. Please help cross check them again
Thanks @ddhuy !
@jaimecasero / @RestComm/vvs-squad does this look good to merge?
i was thinking email is sometimes used as account key, so im not sure making email address modifiable could have some impact. Let me think about it...
