PR ==> Handle DLR for Restcomm Connect SMPP

[imranrazakhan]

I am also working on documentation (http://documentation.telestax.com/connect/api/sms-api.html), which would include how to Send Sms with StatusCallback.

[maria-farooq]

Dear Imran,

Thanks a lot for your PR. Your contribution means a lot to us.

Can you please resolve conflicts on the branch before we move onto assigning it to some team member.

Regards, Maria Telestax

p.s @marca56 can we please take note of it and see it is put in right place in backlog. Thanks.

[imranrazakhan]

@maria-farooq Conflict has been resolved

[maria-farooq]

thanks @imranrazakhan for resolving the conflict. Looking forward to the pending documentation so PR can be assigned to the team for review.

-Maria-

[maria-farooq]

Hi @imranrazakhan

do we have an update here

Regards Maria

[imranrazakhan]

Hi @maria-farooq ,

I was busy and most probably will update tomorrow

Regards

[imranrazakhan]

@maria-farooq documentation updated.

[maria-farooq]

Hi @imranrazakhan After reviewing the PR here is feedback:

• [ ] Pull request is missing automated non regression test
• [ ] As mentioned by Jean in issue description "make sure the CDR reports reflect Delivery recipts" this is missing.
• [ ] Lets use akka asynchronous actor call for posting to StatusCallBack.
• [ ] Lets use guarded logger statements.
• [ ] I see we added 2 new columns (at entity and xml query level), I could not find any schema changes in hsql and mysql scripts, can you please update them as well.
• [ ] were you able to verify test suit after adding new columns to see if any script need changings.
• [ ] please check my code comments on direct files

Please correct me if I have made any comment while missing any details.

Regards Maria

[imranrazakhan]

@maria-farooq i am on vacations, will verify and update accordingly.