requestNetwork icon indicating copy to clipboard operation
requestNetwork copied to clipboard
verified publisher icon RequestNetwork

chore: Enums to Unions

Open benjlevesque opened this issue 4 years ago • 1 comments

Unions are more powerful than enums in TS. To avoid breaking changes, we keep the export of the former enums as variables.

Recommended reading (and inspiration): https://rlee.dev/writing/stop-misusing-typescript-string-enums

benjlevesque avatar Mar 04 '21 21:03 benjlevesque

Coverage Status

Coverage decreased (-0.03%) to 90.4% when pulling e3c6e2531f2d33c9c057372ea8fa7dea6dfd914c on enum-to-union into 9f4f13114d32ad30cedee2187052a41f16a8985f on master.

coveralls avatar Mar 04 '21 22:03 coveralls